-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix categorization for Moderne recipes #167
Comments
if we do this then issues #168 and #169 can be closed. As a follow up, we also have some recipes with org.openrewrite path that are proprietary, and we know what license they have since we display it. This also can be sorted into Moderne Proprietary Categories/Recipes and Categories/Recipes. Then we have a single category catalog that specifies recipes OSS and Moderne for different migrations/tasks. |
Linking this issue here as well as it might clear out some of the discrepancies between OSS docs & Moderne Platform: |
Can we just rename the recipes? Literally run change package name recipe on all these packages in the recipe jars? We're well within the timeframe to be able to rename them. I would rather do that than build something custom for this case. |
We've now renamed the packages, but there's further work to do still:
Waiting to hear if this might help, as I've not wrestled with our categories handling much before: |
I merged the PR Tim had open to mark io.moderne as a root category. I believe that will help |
Right now Moderne recipes are going into strange categories because we've named the recipes weirdly.
For example, our Spring Boot 3.4 recipe - https://docs.openrewrite.org/recipes/recipe/spring/boot3/upgradespringboot_3_4 has a recipe id of:
io.moderne.recipe.spring.boot3.UpgradeSpringBoot_3_4
- which means that it's under the page:recipe
->spring
->boot3
.This is problematic as it should be
Moderne
->Java
->Spring
->Boot3
.This applies to many recipes such as
Hibernate
. Similarly, https://docs.openrewrite.org/recipes/compiled/verification/changelistmethodandverify - this should have a category ofcompiled verification
and notcompiled
->verification
.We need to either rename all of the recipes to have the correct path - or we need to write code to map these recipe ids to categories.
Related thread: https://moderneinc.slack.com/archives/C01VADFPJQZ/p1739899709537709
The text was updated successfully, but these errors were encountered: