Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Better diagnostics on contents of query cache #17024

Open
jhinch-at-atlassian-com opened this issue Jan 14, 2025 · 2 comments
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance Search:Query Insights

Comments

@jhinch-at-atlassian-com

Is your feature request related to a problem? Please describe

Currently you can get the hit, miss and eviction counts for the query cache via the nodes stats API but it can be difficult to diagnose problems with cache efficacy by identifying what gets uses regularly and what is getting evicted.

Describe the solution you'd like

There are two areas I think would help:

  • The ability to enable logging of queries being evicted from the query cache. This likely might need to have some sort of additional threshold which could also be consider to only log when queries over a certain size are evicted
  • The ability to retrieve the the top K queries in the cache and their size.

Related component

Search:Performance

Describe alternatives you've considered

No response

Additional context

No response

@sandeshkr419
Copy link
Contributor

@deshsidd @ansjcy Do you have any comments from Query Insights view point?

@msfroh
Copy link
Collaborator

msfroh commented Jan 21, 2025

The ability to enable logging of queries being evicted from the query cache. This likely might need to have some sort of additional threshold which could also be consider to only log when queries over a certain size are evicted

That would be pretty nice.

@jhinch-at-atlassian-com, what do you think of logging eviction of queries based on some minimum hit count, too? So if a query that's been served from the cache 1 million times gets evicted, we log it?

I think the Query Insights project might be a good sink if we wanted to make it a listener-based solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance Search:Query Insights
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants