Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Need an API to disable/enable monitor #1058

Open
eirsep opened this issue Jul 27, 2023 · 2 comments · May be fixed by opensearch-project/common-utils#770 or #1771
Open

[FEATURE] Need an API to disable/enable monitor #1058

eirsep opened this issue Jul 27, 2023 · 2 comments · May be fixed by opensearch-project/common-utils#770 or #1771
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eirsep
Copy link
Member

eirsep commented Jul 27, 2023

making an update API call to disable or enable a monitor is not the best practice and is also very cumbersome as user would need to be aware of mapping of monitor document.
Since monitors are jobs and require to be enabled or disabled we should provide one of the following:

  1. PUT _plugins/_alerting/monitors/{monitor_id}/enable and PUT _plugins/_alerting/monitors/{monitor_id}/disable
  2. PUT _plugins/_alerting/monitors/{monitor_id}}/status {"enable" = true/false}
@eirsep eirsep added enhancement New feature or request untriaged labels Jul 27, 2023
@lezzago lezzago added good first issue Good for newcomers and removed untriaged labels Sep 7, 2023
@JacobCho-i
Copy link
Contributor

I will work on this one

@adamdepollo
Copy link

This feature would be a huge help for my team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
4 participants