Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Upgrade custom implementation to use Lucene99Codec #94

Closed
mgodwan opened this issue Jan 12, 2024 · 4 comments
Closed

[BUG] Upgrade custom implementation to use Lucene99Codec #94

mgodwan opened this issue Jan 12, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@mgodwan
Copy link
Member

mgodwan commented Jan 12, 2024

OS 2.x branch recently upgraded to use Lucene 9.9.1

We need to evaluate if we require changes in custom-codecs as well to rely on the new codecs introduced.

e.g.
https://github.com/opensearch-project/custom-codecs/blob/main/src/main/java/org/opensearch/index/codec/customcodecs/Lucene95CustomCodec.java#L93C36-L93C49

@mgodwan mgodwan added bug Something isn't working untriaged labels Jan 12, 2024
@mgodwan
Copy link
Member Author

mgodwan commented Jan 12, 2024

If we don't have upgrade tests, I think we also should add the same as part of this exercise.
@sarthakaggarwal97 Can you please check?

@sarthakaggarwal97
Copy link
Collaborator

Thanks @mgodwan for creating the issue. Will take a look.

@andrross
Copy link
Member

#99 has been merged to 2.x. Next we need to forward-port that change to main.

@sarthakaggarwal97
Copy link
Collaborator

Closing this as the change is merged! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants