Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Kafka Producer Callback releases events incorrectly #3680

Open
kkondaka opened this issue Nov 16, 2023 · 0 comments
Open

[BUG] Kafka Producer Callback releases events incorrectly #3680

kkondaka opened this issue Nov 16, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@kkondaka
Copy link
Collaborator

Describe the bug
The following code - has a bug about releasing event handles without trying to push the events to DLQ first.

https://github.com/opensearch-project/data-prepper/blob/main/data-prepper-plugins/kafka-plugins/src/main/java/org/opensearch/dataprepper/plugins/kafka/producer/KafkaCustomProducer.java#L198-L210

It should be fixed such a way that - if DLQ is not configured or DLQ push fails, events should be released with negative ack, otherwise they should be released with positive ack

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS: [e.g. Ubuntu 20.04 LTS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant