You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem?
The build at the moment has a number of limitations that reduce it's portability:
Manual installation of dependencies on local machine is required
Source code is referring to a specific commit for FAISS and NMSLIB and can't be changed or updated for different platforms. For example the following will break for MacOS but will pass for other OS however newer versions will work for MacOS but might break on older version of linux
This suggestion will suggest to switch to a number of best practices when depending on source code that will increase portability and automation of the build across platform.
What solution would you like?
We need to leverage cmake fetch content in order to avoid including source code from other repos in our build. this is also easier to automate by checking the platform architecture and OS during build time.
For example:
Is your feature request related to a problem?
The build at the moment has a number of limitations that reduce it's portability:
This suggestion will suggest to switch to a number of best practices when depending on source code that will increase portability and automation of the build across platform.
What solution would you like?
We need to leverage cmake fetch content in order to avoid including source code from other repos in our build. this is also easier to automate by checking the platform architecture and OS during build time.
For example:
FetchContent_Declare( faiss URL https://github.com/facebookresearch/faiss.git GIT_TAG d243e628880676332263347817b3fe7f474b8b5b # v1.9.0 )
What alternatives have you considered?
NA
The text was updated successfully, but these errors were encountered: