Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve build to pull transient source dependencies #2421

Open
sam-herman opened this issue Jan 22, 2025 · 2 comments
Open

[FEATURE] Improve build to pull transient source dependencies #2421

sam-herman opened this issue Jan 22, 2025 · 2 comments
Assignees
Labels
enhancement Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@sam-herman
Copy link
Contributor

Is your feature request related to a problem?
The build at the moment has a number of limitations that reduce it's portability:

  1. Manual installation of dependencies on local machine is required
  2. Source code is referring to a specific commit for FAISS and NMSLIB and can't be changed or updated for different platforms. For example the following will break for MacOS but will pass for other OS however newer versions will work for MacOS but might break on older version of linux

This suggestion will suggest to switch to a number of best practices when depending on source code that will increase portability and automation of the build across platform.

What solution would you like?
We need to leverage cmake fetch content in order to avoid including source code from other repos in our build. this is also easier to automate by checking the platform architecture and OS during build time.
For example:

FetchContent_Declare(
  faiss
  URL     https://github.com/facebookresearch/faiss.git
  GIT_TAG d243e628880676332263347817b3fe7f474b8b5b # v1.9.0
)

What alternatives have you considered?
NA

@navneet1v
Copy link
Collaborator

cc: @0ctopus13prime who is one of the expert in C/C++ code.

@navneet1v navneet1v moved this from Backlog to Backlog (Hot) in Vector Search RoadMap Jan 23, 2025
@navneet1v navneet1v added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Jan 23, 2025
@sam-herman
Copy link
Contributor Author

@navneet1v @0ctopus13prime can you assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
Status: Backlog (Hot)
Development

No branches or pull requests

2 participants