From 1809b2088a7e4e26fcf786748ac8aeba1aa032de Mon Sep 17 00:00:00 2001 From: "opensearch-trigger-bot[bot]" <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Date: Fri, 5 Apr 2024 10:20:38 -0700 Subject: [PATCH] set only_run_on_ml_node default value to false (#2294) (#2296) Signed-off-by: Jing Zhang (cherry picked from commit 410753ab1e9ab420b7152dd15af782711743eac2) Co-authored-by: Jing Zhang --- .../ml/engine/httpclient/MLHttpClientFactoryTests.java | 2 +- .../main/java/org/opensearch/ml/settings/MLCommonsSettings.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ml-algorithms/src/test/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactoryTests.java b/ml-algorithms/src/test/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactoryTests.java index 9c98be7ee0..fa22837249 100644 --- a/ml-algorithms/src/test/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactoryTests.java +++ b/ml-algorithms/src/test/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactoryTests.java @@ -34,7 +34,7 @@ public void test_validateIp_validIp_noException() throws UnknownHostException { @Test public void test_validateIp_invalidIp_throwException() throws UnknownHostException { expectedException.expect(UnknownHostException.class); - MLHttpClientFactory.validateIp("www.zaniu.com"); + MLHttpClientFactory.validateIp("www.makesureitisaunknownhost.com"); } @Test diff --git a/plugin/src/main/java/org/opensearch/ml/settings/MLCommonsSettings.java b/plugin/src/main/java/org/opensearch/ml/settings/MLCommonsSettings.java index ba0c13e614..6cc4029e78 100644 --- a/plugin/src/main/java/org/opensearch/ml/settings/MLCommonsSettings.java +++ b/plugin/src/main/java/org/opensearch/ml/settings/MLCommonsSettings.java @@ -37,7 +37,7 @@ private MLCommonsSettings() {} public static final Setting ML_COMMONS_MAX_ML_TASK_PER_NODE = Setting .intSetting("plugins.ml_commons.max_ml_task_per_node", 10, 0, 10000, Setting.Property.NodeScope, Setting.Property.Dynamic); public static final Setting ML_COMMONS_ONLY_RUN_ON_ML_NODE = Setting - .boolSetting("plugins.ml_commons.only_run_on_ml_node", true, Setting.Property.NodeScope, Setting.Property.Dynamic); + .boolSetting("plugins.ml_commons.only_run_on_ml_node", false, Setting.Property.NodeScope, Setting.Property.Dynamic); public static final Setting ML_COMMONS_ENABLE_INHOUSE_PYTHON_MODEL = Setting .boolSetting("plugins.ml_commons.enable_inhouse_python_model", false, Setting.Property.NodeScope, Setting.Property.Dynamic);