From a3f1d620eb13e562d596fbcc1e531c6a0f3fbc5d Mon Sep 17 00:00:00 2001 From: Xun Zhang Date: Thu, 18 Jan 2024 12:17:28 -0800 Subject: [PATCH] remove printout leftovers in tests Signed-off-by: Xun Zhang --- .../action/conversation/CreateInteractionRequestTests.java | 2 -- .../memory/action/conversation/GetInteractionResponseTests.java | 1 - .../ml/memory/action/conversation/GetTracesResponseTests.java | 1 - .../org/opensearch/ml/engine/memory/MLMemoryManagerTests.java | 1 - .../ml/action/register/TransportRegisterModelAction.java | 2 +- 5 files changed, 1 insertion(+), 6 deletions(-) diff --git a/memory/src/test/java/org/opensearch/ml/memory/action/conversation/CreateInteractionRequestTests.java b/memory/src/test/java/org/opensearch/ml/memory/action/conversation/CreateInteractionRequestTests.java index 155edbc3c8..8068a85dfb 100644 --- a/memory/src/test/java/org/opensearch/ml/memory/action/conversation/CreateInteractionRequestTests.java +++ b/memory/src/test/java/org/opensearch/ml/memory/action/conversation/CreateInteractionRequestTests.java @@ -108,8 +108,6 @@ public void testFromRestRequest() throws IOException { .withContent(new BytesArray(gson.toJson(params)), MediaTypeRegistry.JSON) .build(); CreateInteractionRequest request = CreateInteractionRequest.fromRestRequest(rrequest); - System.out.println(request.getConversationId()); - System.out.println(request.getInput()); assert (request.validate() == null); assert (request.getConversationId().equals("cid")); diff --git a/memory/src/test/java/org/opensearch/ml/memory/action/conversation/GetInteractionResponseTests.java b/memory/src/test/java/org/opensearch/ml/memory/action/conversation/GetInteractionResponseTests.java index 2cadd7948a..fd41105b9c 100644 --- a/memory/src/test/java/org/opensearch/ml/memory/action/conversation/GetInteractionResponseTests.java +++ b/memory/src/test/java/org/opensearch/ml/memory/action/conversation/GetInteractionResponseTests.java @@ -73,7 +73,6 @@ public void testToXContent() throws IOException { XContentBuilder builder = XContentBuilder.builder(XContentType.JSON.xContent()); response.toXContent(builder, ToXContent.EMPTY_PARAMS); String result = BytesReference.bytes(builder).utf8ToString(); - System.out.println(result); String expected = "{\"memory_id\":\"cid\",\"message_id\":\"iid\",\"create_time\":\"" + interaction.getCreateTime() + "\",\"input\":\"inp\",\"prompt_template\":\"pt\",\"response\":\"rsp\",\"origin\":\"ogn\",\"additional_info\":{\"metadata\":\"some meta\"}}"; diff --git a/memory/src/test/java/org/opensearch/ml/memory/action/conversation/GetTracesResponseTests.java b/memory/src/test/java/org/opensearch/ml/memory/action/conversation/GetTracesResponseTests.java index 87a96a16f3..8a1232d991 100644 --- a/memory/src/test/java/org/opensearch/ml/memory/action/conversation/GetTracesResponseTests.java +++ b/memory/src/test/java/org/opensearch/ml/memory/action/conversation/GetTracesResponseTests.java @@ -93,7 +93,6 @@ public void testToXContent_MoreTokens() throws IOException { XContentBuilder builder = XContentBuilder.builder(XContentType.JSON.xContent()); response.toXContent(builder, ToXContent.EMPTY_PARAMS); String result = BytesReference.bytes(builder).utf8ToString(); - System.out.println(result); String expected = "{\"traces\":[{\"memory_id\":\"cid\",\"message_id\":\"id0\",\"create_time\":" + trace.getCreateTime() + ",\"input\":\"input\",\"prompt_template\":\"pt\",\"response\":\"response\",\"origin\":\"origin\",\"additional_info\":{\"metadata\":\"some meta\"},\"parent_message_id\":\"parent_id\",\"trace_number\":1}],\"next_token\":2}"; diff --git a/ml-algorithms/src/test/java/org/opensearch/ml/engine/memory/MLMemoryManagerTests.java b/ml-algorithms/src/test/java/org/opensearch/ml/engine/memory/MLMemoryManagerTests.java index 185b116b85..68355d9a68 100644 --- a/ml-algorithms/src/test/java/org/opensearch/ml/engine/memory/MLMemoryManagerTests.java +++ b/ml-algorithms/src/test/java/org/opensearch/ml/engine/memory/MLMemoryManagerTests.java @@ -264,7 +264,6 @@ public void testGetInteractions_NoAccessNoUser_ThenFail() { mlMemoryManager.getFinalInteractions("cid", 10, interactionListActionListener); ArgumentCaptor argCaptor = ArgumentCaptor.forClass(Exception.class); verify(interactionListActionListener, times(1)).onFailure(argCaptor.capture()); - System.out.println(argCaptor.getValue().getMessage()); assert (argCaptor.getValue().getMessage().equals("User [] does not have access to conversation cid")); } diff --git a/plugin/src/main/java/org/opensearch/ml/action/register/TransportRegisterModelAction.java b/plugin/src/main/java/org/opensearch/ml/action/register/TransportRegisterModelAction.java index 0261d55b24..ca226f0251 100644 --- a/plugin/src/main/java/org/opensearch/ml/action/register/TransportRegisterModelAction.java +++ b/plugin/src/main/java/org/opensearch/ml/action/register/TransportRegisterModelAction.java @@ -299,7 +299,7 @@ private void registerModel(MLRegisterModelInput registerModelInput, ActionListen throw new IllegalArgumentException("URL can't match trusted url regex"); } } - System.out.println("registering the model"); + boolean isAsync = registerModelInput.getFunctionName() != FunctionName.REMOTE; MLTask mlTask = MLTask .builder()