Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]-(flaky tests) RestMLInferenceSearchResponseProcessorIT Model NOT Found Exception #3228

Closed
mingshl opened this issue Nov 18, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mingshl
Copy link
Collaborator

mingshl commented Nov 18, 2024

What is the bug?
Need to confirm the model id is available after model creation tasks. Sometime the model creation is not completed then the later tests using the model id cannot find the model.

How can one reproduce the bug?

RestMLInferenceSearchResponseProcessorIT > testMLInferenceProcessorRemoteModelStringField STANDARD_ERROR
    REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.rest.RestMLInferenceSearchResponseProcessorIT.testMLInferenceProcessorRemoteModelStringField" -Dtests.seed=9E7BCE94AFC0318E -Dtests.security.manager=false -Dtests.locale=luy-KE -Dtests.timezone=Asia/Dubai -Druntime.java=21

RestMLInferenceSearchResponseProcessorIT > testMLInferenceProcessorRemoteModelStringField FAILED
    org.opensearch.client.ResponseException: method [POST], host [http://127.0.0.1:33169/], URI [/_plugins/_ml/models/null/_deploy], status line [HTTP/1.1 404 Not Found]
    {"error":{"root_cause":[{"type":"status_exception","reason":"Failed to find model"}],"type":"status_exception","reason":"Failed to find model"},"status":404}

What is your host/environment?

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.

@brianf-aws
Copy link
Contributor

I was trying to take a look at this but I can't seem to understand a scenario where this doesn't work. it calls the following.

// In setup()
this.bedrockEmbeddingModelId = registerRemoteModel(bedrockEmbeddingModelConnectorEntity, bedrockEmbeddingModelName, true);

In the above method it will try to deploy the model.This is where the could not deploy model error comes from because it states that model_id is null. My only speculation of this happening is that the shape of the response is different compared to a high level key with model_id perhaps its nested on a different machine?

String modelId = (String) responseMap.get("model_id");

@nathaliellenaa
Copy link

I believe this issue was addressed in Zane's PR #3244, do you think we can close this issue? @mingshl

@brianf-aws
Copy link
Contributor

@nathaliellenaa Thanks for noticing that! Zane's issue addresses the exact same method involving this test it also has a similar error response too

    org.opensearch.client.ResponseException: method [POST], host [http://127.0.0.1:45675/], URI [/_plugins/_ml/models/null/_deploy], status line [HTTP/1.1 404 Not Found]

we should be able to close this issue

@github-project-automation github-project-automation bot moved this from On-deck to Done in ml-commons projects Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

4 participants