-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize integration test failure issue creation #4358
Comments
Problem Statement:We run integration test for all available components from the test manifest at the distribution level. This includes running tests for all distributions and architectures such as tarball, RPM, Debian, Windows and architectures such as x64 and arm64. We also create GH issues for all failing components with all details. Example: opensearch-project/dashboards-maps#577 However, the current approach followed is creating new issues for each version, distribution, architecture. This worked well for one distribution (tarball) and 2 architectures (x64, arm64). With increase in the supporting distributions this has lead to creation of many issues per distribution. Also there is a bug with current set up where architecture is not taken into consideration while closing the issue.
Approaches:Approach 1: [Recommended]We can resolve this by maintaining one issue per version similar to build failure issues. The build failure issue can handle various distribution/architecture failures in one workflow as all distributions are build in one go. Hence, proposing to make use of with GH labels. Labels are unique and easy to manage. Creating or commenting on the GH issue when the tests fail is no brainer. However, closing the issue is a challenge as we might not know when to close the issue. It may pass for one distribution and fail for others. Scenario 1: Windows integration test failed for customImportMapDashboards
Scenario 2: Windows integration test passed for customImportMapDashboards In case of integration test passing, the issue should only be close if:
If there are additional labels such as Pros:
Cons:
Approach 2:Continue creating issues per distribution. Pros:
Cons:
|
Is your feature request related to a problem? Please describe
The integration test failures at distribution level created GH issues in respective component repository.
https://github.com/issues?q=is%3Aopen+is%3Aissue+archived%3Afalse+user%3Aopensearch-project+label%3Aautocut+%22%5BAUTOCUT%5D+Integration+Test+%22+
However, creating a new issue for each different is creating more noise. Hence proposing to optimize the GH issue creation process.
Describe the solution you'd like
Create only issues for test failure just like build failure issues and add additional comments for other distributions/architecture/multiple runs.
On the high level this is what the issue will look like:
Describe alternatives you've considered
Keep what it is but do not create GH issues for all distributions.
Additional context
Further enhancements would be to play with labels for ease of understanding with what is the most recent distribution failures platform.
Acceptance Criterias
The text was updated successfully, but these errors were encountered: