Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Refactor and Upgrade to OpenSearch 2.10 #23

Closed
macohen opened this issue Nov 13, 2023 · 3 comments
Closed

[Build] Refactor and Upgrade to OpenSearch 2.10 #23

macohen opened this issue Nov 13, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@macohen
Copy link
Collaborator

macohen commented Nov 13, 2023

Is your feature request related to a problem?

Created a new branch for OpenSearch 2.10, but there is refactoring to do to build successfully.

opensearch-learning-to-rank-base % ./gradlew -Dopensearch.version=2.10.0 -Djava.security.manager=allow -Dbuild.snapshot=false build

Removed the stack trace for less noise.

What solution would you like?

Successful build including integ tests.

@macohen macohen added enhancement New feature or request untriaged labels Nov 13, 2023
@macohen macohen added help wanted Extra attention is needed good first issue Good for newcomers and removed untriaged labels Nov 13, 2023
@macohen macohen changed the title [FEATURE] Upgrade to OpenSearch 2.10 [Build] Refactor and Upgrade to OpenSearch 2.10 Nov 13, 2023
@macohen macohen self-assigned this Dec 31, 2023
@macohen
Copy link
Collaborator Author

macohen commented Dec 31, 2023

I've made a bunch of changes to get the plugin to compile on 2.10. Most tests also pass, but I'm not quite sure how to replace toXContent methods since the changes in 2.9 from core. I believe 5 tests are failing. @noCharger I might be able to take a look late this week, but if you feel like giving it a shot, my latest is here: https://github.com/macohen/opensearch-learning-to-rank-base/tree/2.10

@jzonthemtn
Copy link

@macohen I see this is building now and there's a release for 2.11.1 now. Does that mean this issue can be closed? If so, I can work on a 2.12.0 version.

@macohen
Copy link
Collaborator Author

macohen commented Mar 18, 2024

Go for it!

@macohen macohen closed this as completed Mar 18, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

3 participants