From fc698a746e482b73f5c32cc68de199ba6398f902 Mon Sep 17 00:00:00 2001 From: Kalyan Date: Mon, 6 Nov 2023 08:05:11 +0530 Subject: [PATCH] Fix `MLCommonClient_client.upload_model` (#336) * fix Signed-off-by: kalyan * fix lint Signed-off-by: kalyan * update changelog Signed-off-by: kalyan * update changelog Signed-off-by: kalyan --------- Signed-off-by: kalyan --- CHANGELOG.md | 1 + opensearch_py_ml/ml_commons/ml_commons_client.py | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 32adb4249..a810d313f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Roll over pretrained_model_listing.json because of ml-commons dependency by @thanawan-atc in ([#252](https://github.com/opensearch-project/opensearch-py-ml/pull/252)) - Fix pandas dependency issue in nox session by installing pandas package to python directly by @thanawan-atc in ([#266](https://github.com/opensearch-project/opensearch-py-ml/pull/266)) - Fix conditional job execution issue in model upload workflow by @thanawan-atc in ([#294](https://github.com/opensearch-project/opensearch-py-ml/pull/294)) +- fix bug in `MLCommonClient_client.upload_model` by @rawwar in ([#336](https://github.com/opensearch-project/opensearch-py-ml/pull/336)) ## [1.1.0] diff --git a/opensearch_py_ml/ml_commons/ml_commons_client.py b/opensearch_py_ml/ml_commons/ml_commons_client.py index 57f9fd10b..99162e30a 100644 --- a/opensearch_py_ml/ml_commons/ml_commons_client.py +++ b/opensearch_py_ml/ml_commons/ml_commons_client.py @@ -96,7 +96,9 @@ def upload_model( :rtype: string """ model_id = self._model_uploader._register_model( - model_path, model_config_path, isVerbose + model_path=model_path, + model_meta_path=model_config_path, + isVerbose=isVerbose, ) # loading the model chunks from model index