Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move exporter config to Query Insights level #209

Closed
ansjcy opened this issue Jan 24, 2025 · 1 comment
Closed

[FEATURE] Move exporter config to Query Insights level #209

ansjcy opened this issue Jan 24, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@ansjcy
Copy link
Member

ansjcy commented Jan 24, 2025

Is your feature request related to a problem?

Currently, we have different exporters config for different metrics.
https://opensearch.org/docs/latest/observing-your-data/query-insights/top-n-queries/#configuring-a-local-index-exporter
This is not a good pattern since we don't have specific use cases when users enabled multiple top n metrics, but they only want to exporter certain of them.

What solution would you like?

Instead of search.insights.top_queries.latency.exporter.type, and search.insights.top_queries.delete_after_days
we should do search.insights.top_queries.exporter.type and search.insights.top_queries.exporter.delete_after_days

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@ansjcy
Copy link
Member Author

ansjcy commented Jan 28, 2025

This is fixed in #210

@ansjcy ansjcy closed this as completed Jan 28, 2025
@ansjcy ansjcy removed the untriaged label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant