Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Detector Generated False Findings For Rule "Publicly Accessible RDP Service" #701

Closed
jowg-amazon opened this issue Oct 27, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jowg-amazon
Copy link
Collaborator

jowg-amazon commented Oct 27, 2023

What is the bug?
A detector will generate false findings for the rule "Publicly Accessible RDP Service" if id.orig_h is not mapped to a field.

This is occurring because the rule is based on a not selection so if the field is not mapped to anything, the rule will be triggered.
Screenshot 2023-10-27 at 3 39 21 PM

How can one reproduce the bug?

  1. Create a network detector
  2. Select "Publicly Accessible RDP Service" as the rule but do not map the field id.orig_h
  3. Insert a document into the index and a finding will be triggered

What is the expected behavior?
If the field is not mapped this rule should not be applied/generate findings.

What is your host/environment?

  • OS 2.11
@jowg-amazon jowg-amazon added bug Something isn't working untriaged labels Oct 27, 2023
@jowg-amazon
Copy link
Collaborator Author

Issue was fixed in this PR by adding an exists check in the query:
#852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants