Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dedupe the internal/wait package #530

Open
ffromani opened this issue Mar 4, 2023 · 3 comments
Open

dedupe the internal/wait package #530

ffromani opened this issue Mar 4, 2023 · 3 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@ffromani
Copy link
Member

ffromani commented Mar 4, 2023 •
edited
Loading

The internal/wait package is a superset of deployer/pkg/deployer/wait package. We need to dedupe them, possibly extending the latter with all the features needed by the former, or making it extensible or anything.
@ffromani ffromani added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 4, 2023
@ffromani
Copy link
Member Author

ffromani commented Mar 4, 2023 •
edited
Loading

this is a good first issue but not among the simplest. It's probably a nontrivial task for a newcomer

@ffromani ffromani changed the title dedup the internal/wait package dedupe the internal/wait package Mar 4, 2023
@jlojosnegros
Copy link
Contributor

I would like to give this a try if that is ok with you @ffromani

@ffromani
Copy link
Member Author

go for it

@jlojosnegros jlojosnegros mentioned this issue Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlojosnegros @ffromani