Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check to prevent addition of k8s.io/kubernetes as dep #748

Closed
ffromani opened this issue Oct 27, 2023 · 1 comment · Fixed by #862
Closed

add check to prevent addition of k8s.io/kubernetes as dep #748

ffromani opened this issue Oct 27, 2023 · 1 comment · Fixed by #862
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@ffromani
Copy link
Member

Importing k8s.io/kubernetes as library is not supported and creates significant maintenance burden: any update can break anytime. We spent a very significant amount of energy removing the deps and we should ensure it is not coming back.

We need a check to scan go.mod pre-merge and fail if that dep is pulled - directly or indirectly.
@ffromani ffromani added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 27, 2023
@ffromani ffromani changed the title add test to prevent addition of k8.sio/kubernetes as dep add test to prevent addition of k8s.io/kubernetes as dep Oct 27, 2023
@ffromani
Copy link
Member Author

ffromani commented Oct 27, 2023 •
edited
Loading

these PRs will remove the dep: #732 #734 #746

@ffromani ffromani changed the title add test to prevent addition of k8s.io/kubernetes as dep add check to prevent addition of k8s.io/kubernetes as dep Oct 27, 2023
@jlojosnegros jlojosnegros mentioned this issue Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add check to prevent addition of k8s.io/kubernetes as dep jlojosnegros/numaresources-operator
1 participant
@ffromani