-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from hardcoded extensions to using extensions.json #2445
Comments
Per issue 2445: openshift#2445 Added extensions.json parsing and propagated a few errors since now extension processing can fail. Added a test for extensions.json parsing and filtering. I don't know that I like this. If I understand the workflow right, this feels like something that should maybe be done as part of a validation step when extract the image so we only have to do it once and can check the extensions against the container labels. The package doesn't really "keep state" though (well, aside from the filesystem), it just extracts the image where it's told so this would require additional team conversations.
I think part of the idea behind the hardcoded list in the MCO is that because it can be part of the CRD it can be validated at But that said probably simplest for now is to have a script that machine edits the CRD openapi validation from the current RHCOS build - we aren't going to need to run that very often. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In coreos/coreos-assembler#2028, we now include an
extensions.json
in the m-o-c which details extensions available in the embedded yumrepo, as well as the corresponding RPMs, e.g.:(The MCO should only look at extensions with
kind: os-extension
; the development ones are not meant for layering.)Rather than hardcoding the list of supported extensions, the MCO could now read them from this JSON file and feed the package list to rpm-ostree.
For validation, there is also a
com.coreos.os-extensions
label on the m-o-c which lists the available extensions (see e.g. coreos/coreos-assembler#2028 (comment)).The text was updated successfully, but these errors were encountered: