add: generate aggregate ket metrics models
#2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jabolol
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
![oso-prs[bot]](https://avatars.githubusercontent.com/in/856587?s=60&v=4){kind=small}
|
Test deployment unnecessary, no dbt files have been changed. |
ravenac95
reviewed
Feb 2, 2025
| name=f"metrics.key_metrics_to_{entity_type}", | ||
| is_sql=True, | ||
| kind="VIEW", | ||
| dialect="clickhouse", |
There was a problem hiding this comment.
This makes me realize we need to remove the clickhouse references in this library.
ravenac95
approved these changes
Feb 2, 2025
|
@Jabolol were you able to attempt to run this on |
I have not, but I can run it over the next few days or we can check it out together on Tuesday! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2906 by removing intermediate key metric models in favor of auto-generated models by the SQLMesh factory, following the approach used by time series metrics. It also closes #2898 by addressing feedback regarding column naming.