Not all changesets shown in history view on low zoom levels #3423
Labels
bug
Something is broken or not working as expected
changesets
Related to the Changesets feature
ui
User Interface
URL
https://www.openstreetmap.org/history#map=1/0/0
How to reproduce the issue?
To reproduce issue:
Issue: Only changesets from that very narrow gap are shown.
Expected behaviour: All changesets around the world are shown.
Screenshot(s) or anything else?
The bug is caused by Leaflet's method
.wrap()
on line 62 of history.js. The easiest fix is to simply remove said method because it's used for offsetting user's bbox of current viewport into valid latitude/longitude. However, function that processes the passed parameter in changesets_controller.rb as of now uses simple number comparison to filter changesets and don't mind unusual bbox parameters. Bit more sophisticated fix is to add client-side bbox validation where too large bboxes would be clipped from -180/180 meridian. But bigger question is that since this issue was introduced as single commit 8 years ago and not fixed since, is this a bug or an intentional feature to reduce server load?I came across this bug while working on PR #3417 and had actually already fixed it there using the lazy method, but wanted to clarify if wrapping was intentional or it was added by accident.
Screenshot with sample of the issue (loaded bit more changesets than the default 20 to show the trend). Note the map boundaries.
The text was updated successfully, but these errors were encountered: