Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes after viewing credential #69

Closed
mlisle opened this issue Oct 29, 2021 · 7 comments · Fixed by #74
Closed

App crashes after viewing credential #69

mlisle opened this issue Oct 29, 2021 · 7 comments · Fixed by #74

Comments

@mlisle
Copy link

mlisle commented Oct 29, 2021

I tried adding credentials listed at digitalcredentials/docs#10 and encountered the following:

  1. Add credential using QR code
  2. Upon success, click "Added to Wallet"
  3. Arrive at Credential Preview, Click Home
  4. See credential from step 1. Tap that credential.
  5. App crashes
  6. Upon reopening app, my wallet is empty again.

My wallet remains empty until after I add another credential, at which point I can temporarily see credential from step 1. But once I try to select a credential, the app crashes and my wallet empties again.

@mlisle
Copy link
Author

mlisle commented Oct 29, 2021

iOS 14.8
iPhone 8
Model MQ6V2LL/A

@bmuramatsu
Copy link
Contributor

Try resetting the app and reproducing.

I had something similar happen (on share) but I wasn't able to reproduce after resetting the wallet and doing all the steps over again.

@mlisle
Copy link
Author

mlisle commented Oct 29, 2021

Yup, after resetting and starting from scratch, it didn't happen again. Still a bug you think?

@bmuramatsu
Copy link
Contributor

I'm not sure. Odd that we both had independent crashes. Mine was from a bug of being able to infinitely add the same credential, so I wasn't sure if it had to do with that bug or something else. Let's leave this open and see if others see something similar.

@bmuramatsu
Copy link
Contributor

bmuramatsu commented Nov 2, 2021

Ok I can reproduce this bug.

Reset the wallet. Add a couple credentials from the Setting menu using the dev credential option. Preview any of the credentials. Force close the app--but do not logout. Reopen the app, try and view a credential, it crashes. Reopen app, see no credentials. Add more credential(s). View the home screen (list of credentials). All the previous credentials are there.

Rest wallet. Do the same thing with a QR code added credential. Same problem.

@mlisle Can you try the add, close app, reopen app, preview credential.

@mlisle
Copy link
Author

mlisle commented Nov 4, 2021

@bmuramatsu I can try that. But I just discovered a slightly different way to reproduce this (or should it be a different issue)?...

  • Open Wallet, home screen is empty (no credentials)
  • Switch to Settings
  • Tap "App credential (dev)" (nothing appears to happen)
  • Switch back to home screen... credentials are there again

I can kill the app (double tap home button) and reopen the app... and it happens every time.

@bmuramatsu
Copy link
Contributor

that sounds like the same issue to me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants