Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache opsdroid icon for chat demo #14

Open
pjbollinger opened this issue Oct 8, 2017 · 6 comments
Open

Cache opsdroid icon for chat demo #14

pjbollinger opened this issue Oct 8, 2017 · 6 comments

Comments

@pjbollinger
Copy link
Contributor

While working on adding blog posts to the site, I noticed a network request every time the opsdroid icon appeared in the chat demo. Ideally, this should be stored on the local machine at first load so the request never has to be completed again, until the page reloads.

screen shot 2017-10-08 at 10 00 28 am

@jacobtomlinson
Copy link
Member

This is definitely something that should be fixed. Thanks!

@pjbollinger
Copy link
Contributor Author

I should add that I experience this lack of cache in Safari on High Sierra (will get specific numbers later) but not on Google Chrome Canary 57.0.2985.0 on Windows 7. Not sure, but I feel it’s related to how Safari determines cache and how Jekyll server reports what can be cached.

@Pratik-ahirrao
Copy link

I want to do my 1st contribution. Can I work on this issue?
Can you please help me with that?

@himansh-gjr
Copy link

hey @jacobtomlinson I would like to work on this issue, is it still open @pjbollinger ?

@FabioRosado
Copy link
Member

@himansh-gjr Feel free to open a PR with this changes as this is still open, thank you

@himansh-gjr
Copy link

Sure, Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants