New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OptionsContract.calculateOTokens(uint256,OptionsContract.Number) (OptionsContract.sol#908-943) performs a multiplication on the result of a division #152

Open

ghost opened this issue Aug 11, 2020 · 0 comments

Labels

crytic

ghost commented Aug 11, 2020

OptionsContract.calculateOTokens(uint256,OptionsContract.Number) performs a multiplication on the result of a division:
-numeratorVal = (collateralAmt.mul(collateralToEthPrice)).div(strikeToEthPrice)
-numOptions = numeratorVal.mul(10 ** exp).div(denomVal)

Consider ordering multiplication prior division.

antoncoding added the crytic label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment