Personalized pages don't work with External Login users (perhaps due to the username being an email, so having @)

[patrickjlee]

hi - am really enjoying using Oqtane, but am finding a problem with its Personalized page feature, e.g. for a page called mypage.

If I have a local user with a username without an @ e.g. SomeName then the Personalized page works fine: when the user clicks on the pencil icon to edit mypage, a copy of the page is created at mypage/SomeName and that page is then visible at that url.

But if I use a social media login, e.g. from LinkedIn, then the username is likely to be an email address, e.g. [email protected]
and although when the user is logged in and clicks on the pencil icon on mypage, the new page seems to be created with url mypage/[email protected] (I can see it in the Page table of the database) but:
a) that page can't seem to be accessed, if you put it in an incognito browser, you get a 404 (page not found) error,
and
b) similarly, the user can't seem to edit the page on returning to it later.

And also, because it seems that UserName can't be changed after a user has been created, I can't solve this by changing the user's username to something without an @.

Any suggestions as to how I can fix this please?

Thanks

[sbwalker]

@patrickjlee Urls cannot contain @ characters... so the problem is that the personalized page route does not encode/substitute it with a valid character. In order to create "clean" routes it could substitute characters with a "-" (similar to how the blog module creates slugs from titles). This would create the potential for duplicate routes (ie. if 1 user had a username of john-smith and another had a username of john@smith) however the probability of this occurring is so low that I would not worry about it.

[sbwalker]

@patrickjlee #4989 resolves this issue

[patrickjlee]

Thanks ! That seems to fix it, apart from the navigation part:
If the personalized page is called Personalized, and is included in the navigation menu at the end (with the site root as the parent), then when a user with name john@smith edits the page, although a page with url personalized/john-smith now gets created behind the scenes, the url shown in the address bar remains unchanged as personalized.

And when that user clicks on the Personalized menu, they get taken to url personalized rather than personalized/john-smith. If they click the pencil icon again, they can then edit the personalized page rather than the personalized/john-smith one (so they are actually altering the parent/template page rather than their own personalized copy).

In contrast for a user with name JohnSmith, when they edit Personalize, the url changes immediately to personalize/johnsmith and if the click on the Personalize navigation menu, they get taken to personalize/johnsmith?

[sbwalker]

@patrickjlee this is now resolved in #4991. There is another problem I identified during testing where if a registered user on a personalized page tries to access the Edit Page option it results in a 404. This is a result of a "fix" applied in #4479 which will need further investigation. For now the workaround is to add View access to the Registered Users role for the admin/pages Page. One other limitation of personalized pages is that the page path currently cannot be modified - so if the path was created as "john-smith-domain-com" (ie. the username was [email protected]") it cannot be changed - which is not very friendly. However the enhancement to address this would require a lot of work - and will not be prioritized as there are other items which are more critical.

[patrickjlee]

Thanks @sbwalker . I've applied the fix in #4991 to the 2 files, but it still doesn't seem to stop the user with an @ in their username from being stuck on the personalized page rather from being redirected (when they click on the personalized navigation link, or click the Edit pencil button on the personalized page) to the personalized/john-smith one. Apologies if I am missing something here - I much appreciate the prompt responses you provided so far :)

[sbwalker]

@patrickjlee you would need to create a new user account in your environment and login as that user before browsing to My Page and clicking the Edit icon.

[sbwalker]

@patrickjlee I was not happy with some aspects of personalized pages so I made some improvements in PR #4993:

• instead of having a hard-coded path mapping between the username and the personalized page, the framework now stores the path in the user's profile
• the default value for the personalized page path is still based on the username (ie. when the user selects the Edit icon to create their personalized page)
• once a user is redirected to their personalized page they can choose Edit from Page Management in the Control Panel and they will have the ability to modify the path

[patrickjlee]

Thank you very much @sbwalker
Yes, I think the ability to change the path to the personalized page is a very nice addition.

Incidentally I realised why the routing still wasn't working for me after applying the changes in #4991. I don't think creating a new user is necessary, the problem was because my user had editing rights on the personalize page. In that situation, the user can still create a personalized page, but to get to it has to enter its url by hand (personalized/john-smith) rather than clicking on the navigation link to the (parent) personalized page.

[markdav-is]

I'm working on a product where every user will be able to create sub-sites similar to My Page. I have not investigated how My Page is handled differently from other pages, but I feel like that's the best way to handle this sort of thing. If I'm following the above conversation, the path will be /personalized/page-name. Do we have control over the root of the slug, or is it always /personalized/. I'll pull the latest dev and play around a bit.

[sbwalker]

A personalized page cannot be a root page... it is a child of a personalizable page. So if you have a personalizable root page with a path of "mypage" then it's personalized child pages will have paths of "mypage/page-name" (and "page-name" will default to the username of the user who created the page)

[markdav-is]

I'm understanding better now after your comments and running the latest dev build. I see that if I'm building root pages for folks, I'll have to do that programmatically and assign them editor roles for those pages. the other option is to build entire sites for individual users, but I push that thought down for a bit.

I did notice a pub where the personal page setting are not editable by the user who created it. I think that was mentioned above as well. If there's no bug reported for that, I'll make one.

[markdav-is]

#5061