From 8466c52e0846da8dc5e027853a882e19ca1489fc Mon Sep 17 00:00:00 2001
From: Julien <76999467+Julien-Livet@users.noreply.github.com>
Date: Fri, 25 Oct 2024 19:47:55 +0200
Subject: [PATCH 1/2] Update operations.py

Add extraction on u and v axis from a surface
---
 geomdl/operations.py | 112 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 112 insertions(+)

diff --git a/geomdl/operations.py b/geomdl/operations.py
index 95bc0902..516faf9e 100644
--- a/geomdl/operations.py
+++ b/geomdl/operations.py
@@ -1683,3 +1683,115 @@ def flip(surf, **kwargs):
         g.set_ctrlpts(new_cpts, size_u, size_v)
 
     return geom
+
+
+@export
+def extract_curve_u(obj, param, **kwargs):
+    """ Extracts the curve at the input parametric coordinate on the u-direction.
+
+    Keyword Arguments:
+        * ``find_span_func``: FindSpan implementation. *Default:* :func:`.helpers.find_span_linear`
+        * ``insert_knot_func``: knot insertion algorithm implementation. *Default:* :func:`.operations.insert_knot`
+
+    :param obj: surface
+    :type obj: abstract.Surface
+    :param param: parameter for the u-direction
+    :type param: float
+    :return: a curve
+    :rtype: curve
+    """
+    # Validate input
+    if not isinstance(obj, abstract.Surface):
+        raise GeomdlException("Input shape must be an instance of abstract.Surface class")
+
+    # Keyword arguments
+    span_func = kwargs.get('find_span_func', helpers.find_span_linear)  # FindSpan implementation
+    insert_knot_func = kwargs.get('insert_knot_func', insert_knot)  # Knot insertion algorithm
+
+    # Find multiplicity of the knot
+    ks = span_func(obj.degree_u, obj.knotvector_u, obj.ctrlpts_size_u, param) - obj.degree_u + 1
+    s = helpers.find_multiplicity(param, obj.knotvector_u)
+    r = obj.degree_u - s
+
+    # Create backups of the original surface
+    temp_obj = copy.deepcopy(obj)
+
+    # Split the original surface
+    insert_knot_func(temp_obj, [param, None], num=[r, 0], check_num=False)
+
+    # Control points
+    if (param == 0):
+        curve_ctrlpts = temp_obj.ctrlpts2d[0]    
+    elif (param == 1):
+        curve_ctrlpts = temp_obj.ctrlpts2d[-1]    
+    else:
+        curve_ctrlpts = temp_obj.ctrlpts2d[ks + r - 1]
+
+    # Create a new curve
+    from geomdl import NURBS
+    curve = NURBS.Curve()
+    curve.degree = obj.degree_v
+    curve.ctrlpts = curve_ctrlpts
+    curve.knotvector = obj.knotvector_v
+
+    # Return the new curve
+    return curve
+
+
+@export
+def extract_surface_v(obj, param, **kwargs):
+    """ Extracts the curve at the input parametric coordinate on the v-direction.
+
+    Keyword Arguments:
+        * ``find_span_func``: FindSpan implementation. *Default:* :func:`.helpers.find_span_linear`
+        * ``insert_knot_func``: knot insertion algorithm implementation. *Default:* :func:`.operations.insert_knot`
+
+    :param obj: surface
+    :type obj: abstract.Surface
+    :param param: parameter for the v-direction
+    :type param: float
+    :return: a curve
+    :rtype: curve
+    """
+    # Validate input
+    if not isinstance(obj, abstract.Surface):
+        raise GeomdlException("Input shape must be an instance of abstract.Surface class")
+
+    # Keyword arguments
+    span_func = kwargs.get('find_span_func', helpers.find_span_linear)  # FindSpan implementation
+    insert_knot_func = kwargs.get('insert_knot_func', insert_knot)  # Knot insertion algorithm
+
+    # Find multiplicity of the knot
+    ks = span_func(obj.degree_v, obj.knotvector_v, obj.ctrlpts_size_v, param) - obj.degree_v + 1
+    s = helpers.find_multiplicity(param, obj.knotvector_v)
+    r = obj.degree_v - s
+
+    # Create backups of the original surface
+    temp_obj = copy.deepcopy(obj)
+
+    # Split the original surface
+    insert_knot_func(temp_obj, [None, param], num=[0, r], check_num=False)
+
+    # Control points
+    curve_ctrlpts = []
+    idx = 0
+    if (param == 0):
+        idx = 0
+    elif (param == 1):
+        idx = -1
+    else:
+        idx = ks + r - 1
+    for v_row in temp_obj.ctrlpts2d:
+        temp = v_row[idx]
+        curve_ctrlpts.append(temp)
+
+    # Create a new curve
+    from geomdl import NURBS
+    curve = NURBS.Curve()
+    curve.degree = obj.degree_u
+    curve.ctrlpts = curve_ctrlpts
+    curve.knotvector = obj.knotvector_u
+
+    # Return the new curve
+    return curve
+

From 06737f7dc484fed1282d93e9950540b16fd5e0a5 Mon Sep 17 00:00:00 2001
From: Julien <76999467+Julien-Livet@users.noreply.github.com>
Date: Tue, 29 Oct 2024 11:06:55 +0100
Subject: [PATCH 2/2] Update operations.py

---
 geomdl/operations.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/geomdl/operations.py b/geomdl/operations.py
index 516faf9e..c6df82f0 100644
--- a/geomdl/operations.py
+++ b/geomdl/operations.py
@@ -1721,9 +1721,9 @@ def extract_curve_u(obj, param, **kwargs):
 
     # Control points
     if (param == 0):
-        curve_ctrlpts = temp_obj.ctrlpts2d[0]    
+        curve_ctrlpts = obj.ctrlpts2d[0]    
     elif (param == 1):
-        curve_ctrlpts = temp_obj.ctrlpts2d[-1]    
+        curve_ctrlpts = obj.ctrlpts2d[-1]    
     else:
         curve_ctrlpts = temp_obj.ctrlpts2d[ks + r - 1]
 
@@ -1739,7 +1739,7 @@ def extract_curve_u(obj, param, **kwargs):
 
 
 @export
-def extract_surface_v(obj, param, **kwargs):
+def extract_curve_v(obj, param, **kwargs):
     """ Extracts the curve at the input parametric coordinate on the v-direction.
 
     Keyword Arguments:
@@ -1775,13 +1775,16 @@ def extract_surface_v(obj, param, **kwargs):
     # Control points
     curve_ctrlpts = []
     idx = 0
+    o = temp_obj
     if (param == 0):
         idx = 0
+        o = obj
     elif (param == 1):
         idx = -1
+        o = obj
     else:
         idx = ks + r - 1
-    for v_row in temp_obj.ctrlpts2d:
+    for v_row in o.ctrlpts2d:
         temp = v_row[idx]
         curve_ctrlpts.append(temp)