Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should have [global] section in config file #243

Open
sshipway opened this issue Sep 1, 2014 · 2 comments
Open

Should have [global] section in config file #243

sshipway opened this issue Sep 1, 2014 · 2 comments

Comments

@sshipway
Copy link
Contributor

sshipway commented Sep 1, 2014

Certain options, which apply to both dungeons and to treasue hunts, currently live in the [dungeon] section of the config file. These should probably be moved to a [global] section to more clearly indicate that they affect treasurehunts as well. Examples would be max_dist and min_dist, Spawn*, structures, *_biomes, silverfish

It would probably be necessary to retain backwards compatibility with older cfg files, meaning that if global.X is not set, then use dungeon.X instead, else use the default.

This is fairly easy to code up -- I've already done much of the work in my branch -- but I'd like to hear if this is in line with your design philosophy before submitting a pull req. This would also mean a certain amount of documentation changes.

@orphu
Copy link
Owner

orphu commented Sep 1, 2014

Not for the initial release for 1.8. Too much can break here and there's not enough time to test it well.

@JiFish
Copy link
Collaborator

JiFish commented Sep 14, 2014

It would be nice if the [dungeon] section could become entirely optional - like the treasure hunts section.

Rather than worrying about backwards compatibility, it might be enough just to throw a helpful error message when the [global] section is missing. It's a fairly easy fix to the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants