Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error on opening http://osmlab.github.io/learnoverpass/en/exercises/intro/1/ #19

Closed
matkoniecz opened this issue Jun 20, 2018 · 12 comments

Comments

@matkoniecz
Copy link
Contributor

I got

An error occured during the execution of the overpass query!
This is what overpass API returned:



<p><strong style="color:#FF0000">Error</strong>: line 1: parse error: An empty query is not allowed </p>
@abitrolly
Copy link

@bhousel Hi Bryan. Do you know who can fix the tutorial? In https://wiki.openstreetmap.org/wiki/Overpass_API/Overpass_QL I couldn't find a minimal example.

@bhousel
Copy link
Member

bhousel commented Sep 3, 2019

Hi Bryan. Do you know who can fix the tutorial?

Sorry I don't know! It looks like this is no longer maintained.

@abitrolly
Copy link

Nobody from @osmlab who know how it works?

@irnc
Copy link
Contributor

irnc commented Sep 15, 2019

@abitrolly This issue is fixed in pull request #22.

/cc @bhousel @Secretmapper @tyrasd I would be happy to become maintainer of LearnOverpass. Please see pull requests #21 and #22 which restore main functionality.

After restoration work I have the following plan:

  • fix non-critical errors and issues
  • do a code cleanup
  • port to upstream i18n support in Hugo
  • ask community for exercise translations

@bhousel
Copy link
Member

bhousel commented Sep 16, 2019

I would be happy to become maintainer of LearnOverpass. Please see pull requests #21 and #22 which restore main functionality.

Thanks @irnc , I've invited you to be the maintainer for the project!

irnc added a commit that referenced this issue Sep 19, 2019
catch_alert message was replaced by silent parameter at [1]

This change fixes issue #19.

[1]: tyrasd/overpass-turbo@bd304a6
@irnc
Copy link
Contributor

irnc commented Sep 19, 2019

This issue was fixed by 34e352d.

Fix was deployed to https://osmlab.github.io/learnoverpass/en/, so feel free to use it, but keep in mind that we have another known issue #24 which sometimes causes Run Query button to be disabled. Until it is fixed, please use LearnOverpass in non-incognito mode and refresh page when Run Query button is disabled on initial page load.

@irnc irnc closed this as completed Sep 19, 2019
@abitrolly
Copy link

I hit #24 too and had to refresh the page.

The initial query is invalid and gives the error.

image

What is the valid minimal query to insert on the first page?

@irnc
Copy link
Contributor

irnc commented Sep 20, 2019

First exercise is solved by the following query:

node(48.5657094, 13.4490548, 48.5662416, 13.4501676);
out;

If you already tried it, please try again ;) as a fix for #25 was just deployed. That issue prevented almost all exercises to pass.

@Secretmapper
Copy link
Contributor

Thanks @irnc! Apologies for the late reply, I've caught the flu last week.

It looks like you have access to the repo now ^_^ Let me know if there's anything else you might need from me

@abitrolly
Copy link

abitrolly commented Sep 24, 2019

There is still the error on the map when the page is loaded. Starting tutorial with the error is not a good user experience, because you can never tell if the error is intentional, or it is a broken tutorial. I suspected a broken tutorial after overpass syntax change, that's why I asked for a minimal valid query.

Another problem is that syntax like node(48.5657, 13.44, 48.5662, 13.45); is perfectly valid, and the map renders successfully, but the error message is misleading:

image

If the syntax is right, I would expect it to say "The syntax is correct. Try to enter exact GPS coordinates to pass to the next exercise.".

@irnc
Copy link
Contributor

irnc commented Sep 24, 2019

@Secretmapper Thanks! Hope you are doing well. I will work on the roadmap soon to make project better prepared for new contributors. I would be glad to receive feedback on it once it is drafted.

@abitrolly Thanks for feedback, these are all good points! Could you please extract them into separate issues, so they could be worked out independently?

@abitrolly
Copy link

@irnc moved the aforementioned points into #32 and #33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants