Enable noetic desktop and desktop-full?

[lucasw]

I see they are commented out here, could they be brought back?

https://github.com/osrf/docker_images/blob/master/ros/noetic/debian/buster/Makefile#L17-L18

(and presumably the osrf/ part of the prefix is chopped of as in the other entries)

[sloretz]

It's the same for ROS Melodic. I think it has something to do with the images that are built for https://hub.docker.com/_/ros not being allowed to include GUIs, while the images in https://hub.docker.com/r/osrf/ros/ can.

[lucasw]

That no-gui policy is self-imposed?

I found this clue for kinetic, looks like melodic and noetic makefiles were copied and pasted from it without additional comment

Omitting the build of ros desktop from dockerfile CI build
To keep reported CI errors pertinent to official ROS images

3e8b29c

[sloretz]

That no-gui policy is self-imposed?

No, it was something imposed to become one of the Docker "Official Images", but I can't find it in the review guidelines. It maybe documented elsewhere, or may no longer be a rule.

[ruffsl]

That no-gui policy is self-imposed?

I think this was something the reviewers requested when ROS and Gazebo images were first proposed:

docker-library/official-images#855 (comment)

[ruffsl]

Closing with #588 (comment)

[lucasw]

@ruffsl these lines in #598 will cause noetic desktop-full images to now be built?

https://github.com/osrf/docker_images/pull/598/files#diff-e49dfb7f1eced7c964df798cb27309e0aa34505f6db7a9201c08bfc9f62696a4R48-R58

If so do they appear on https://hub.docker.com/_/ros eventually, or somewhere else now?

I see some in https://hub.docker.com/r/osrf/ros/tags (https://hub.docker.com/layers/osrf/ros/noetic-desktop-full/images/sha256-4aa8dfb806609f3da03b30f686620f91439b04174387783c2b3710dd45eba377?context=explore), thanks!