added alert when duplicate file is selected #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suprajamannava17
requested a review
from SiriChandanaGarimella
as a code owner
2 tasks
| @@ -18,14 +18,19 @@ const OrcaDashboardComponent = () => { | |||
| const isSectionsEmpty = sections.length === 0; | |||
| const [sameCriteria, setSameCriteria] = useState(false); | |||
| const [previewContent, setPreviewContent] = useState(""); | |||
| const [showPreviewModal, setShowPreviewModal] = useState(false); | |||
There was a problem hiding this comment.
Make sure that the spacing issue is done correctly so that it will not show many red line and green line additions.
|
|
||
| const onFileSelected = (event) => { | ||
| const selectedFile = event.target.files[0]; | ||
| if (selectedFile.type !== "text/plain") { | ||
| alert("Invalid file type. Please upload a .txt file."); | ||
| return; | ||
| } | ||
|
|
||
| if (uploadedFiles.includes(selectedFile.name)) { |
There was a problem hiding this comment.
Apt logic well done
bhumulanandinireddy
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129
What was changed?
Added an alert for duplicate file selection in OrcaDashboardComponent.js
Why was it changed?
Previously, users could upload the same file multiple times without any indication, leading to duplicate uploads.
How was it changed?
Modified onFileSelected and onUpload in OrcaDashboardComponent.js to check for duplicate files and trigger an alert if the same file is selected again.
Screenshots that show the changes (if applicable):
