Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify and refactor logic/data coupling issues (primarily in classmethods of app/objects classes) #201

Open
cmyui opened this issue Mar 22, 2022 · 1 comment
Open

Identify and refactor logic/data coupling issues (primarily in classmethods of app/objects classes) #201

cmyui opened this issue Mar 22, 2022 · 1 comment
Assignees
@cmyui
Labels
code quality Something is implemented poorly

Comments

@cmyui
Copy link
Member

cmyui commented Mar 22, 2022 •
edited
Loading

bad classmethods should be refactored into app/usecases folder - more in-depth explanation coming soon:tm:

example of refactoring: 365880b
@cmyui cmyui added the code quality Something is implemented poorly label Mar 22, 2022
@cmyui cmyui self-assigned this Mar 22, 2022
@cmyui cmyui changed the title Identify and logic/data coupling issues in classmethods (primarily in app/objects) Identify and logic/data coupling issues (primarily in classmethods of app/objects classes) Mar 22, 2022
@cmyui cmyui changed the title Identify and logic/data coupling issues (primarily in classmethods of app/objects classes) Identify and refactor logic/data coupling issues (primarily in classmethods of app/objects classes) Mar 22, 2022
@cmyui
Copy link
Member Author

cmyui commented Apr 22, 2022

this is in-progress with #205

@cmyui cmyui linked a pull request Apr 22, 2022 that will close this issue
v5.0.0 - Overall project restructuring & refactoring #205
Closed
@cmyui cmyui mentioned this issue Apr 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmyui cmyui

Labels
code quality Something is implemented poorly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v5.0.0 - Overall project restructuring & refactoring osuAkatsuki/bancho.py
1 participant
@cmyui