Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beatmap submission system #93

Open
cmyui opened this issue Apr 19, 2021 · 6 comments
Open

Beatmap submission system #93

cmyui opened this issue Apr 19, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@cmyui
Copy link
Member

cmyui commented Apr 19, 2021

This one is pretty large compared to any other issues, it entails the implementation of the following handlers:

POST /web/osu-osz2-bmsubmit-post.php
POST /web/osu-osz2-bmsubmit-upload.php
GET /web/osu-osz2-bmsubmit-getid.php
GET /web/osu-get-beatmap-topic.php

along with writing a program to write osz2 files, and quite a few backend changes.
I've already done a few hundred lines of code of this one, but it will likely not be implemented into master for a while to come.

@cmyui cmyui added the enhancement New feature or request label Apr 19, 2021
@cmyui cmyui self-assigned this Apr 19, 2021
@Pure-Peace
Copy link
Contributor

Suggestion: after my experiment, ppy use i32 as beatmap id in osu, other beatmap id type will cause the beatmap can't be read, so we can use negative number as beatmap id. (-1 ~ -2147483648)

If we want different private servers to share each other's beatmap resources, we can consider making a submission site that uses negative numbers as beatmap ids.

@cmyui
Copy link
Member Author

cmyui commented Jun 29, 2021

I think we have to use positive numbers though if we want osu-search-set to work, since osu!'s internal parser won't read the '-' properly.

q2oLv3glVGhYLx7dnobE.mp4

@Pure-Peace
Copy link
Contributor

I think we have to use positive numbers though if we want osu-search-set to work, since osu!'s internal parser won't read the '-' properly.

q2oLv3glVGhYLx7dnobE.mp4

Oh, it does look like this is a problem. ppy's client has strange behavior.

Using positive numbers needs to avoid conflicts with existing maps, a bit tricky

@cmyui
Copy link
Member Author

cmyui commented Jun 29, 2021

Yea, i think i’ll just end up either cutting int32 space in half and starting from halfway, or starting at 2147483647 and counting down.

@Pure-Peace
Copy link
Contributor

Should work, these numbers are temporarily not used up lol

@infernalfire72
Copy link
Contributor

Another problem of using negative IDs is that the osu! client will straight up not submit the map if it receives a negative ID from the server

@tsunyoku tsunyoku self-assigned this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants