From e1ba8dfdc9b7f641bc263e3ef92430b45758229f Mon Sep 17 00:00:00 2001
From: Morgan Bazalgette <the@howl.moe>
Date: Sun, 6 Aug 2017 00:01:23 +0200
Subject: [PATCH] Add status RegClosedRequestsOpen, remove temp fixes

---
 classes/Status.php           | 9 +++++----
 methods/beatmaps/request.php | 5 ++---
 methods/invites/accept.php   | 3 ++-
 registration_validation.php  | 4 ++--
 4 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/classes/Status.php b/classes/Status.php
index 627d349..9248bb6 100644
--- a/classes/Status.php
+++ b/classes/Status.php
@@ -3,8 +3,9 @@
 class Status {
 	const Organising = 0;
 	const Open = 1;
-	const RegClosed = 2;
-	const AwaitRound = 3;
-	const Playing = 4;
-	const Closed = 5;
+	const RegClosedRequestsOpen = 2;
+	const RegClosed = 3;
+	const AwaitRound = 4;
+	const Playing = 5;
+	const Closed = 6;
 }
\ No newline at end of file
diff --git a/methods/beatmaps/request.php b/methods/beatmaps/request.php
index d653b41..9a2a0f6 100644
--- a/methods/beatmaps/request.php
+++ b/methods/beatmaps/request.php
@@ -21,11 +21,10 @@ function run_method($state)
 		error_message("Tournament does not exist.");
 		return;
 	}
-	// TODO: temporary fix
-	/*if ($tourn["max_beatmap_requests"] < 1 || $tourn["status"] != Status::Open) {
+	if ($tourn["max_beatmap_requests"] < 1 || $tourn["status"] > Status::RegClosedRequestsOpen) {
 		error_message("Tournament does not accept beatmap requests.");
 		return;
-	}*/
+	}
 
 	// Decode POST body and check tournament is set
 	$maps = json_decode(file_get_contents('php://input'));
diff --git a/methods/invites/accept.php b/methods/invites/accept.php
index e55a2ec..5a0b308 100644
--- a/methods/invites/accept.php
+++ b/methods/invites/accept.php
@@ -1,6 +1,7 @@
 <?php
 
 require_once __DIR__ . "/../../registration_validation.php";
+require_once __DIR__ . "/../../classes/Status.php";
 
 function run_method($state) {
 	$tok = $state->getAccessToken();
@@ -29,7 +30,7 @@ function run_method($state) {
 
 	$tournID = $state->db->fetch("SELECT tournament FROM teams WHERE id = ? LIMIT 1", $teamID)["tournament"];
 
-	if (!validate_registration($state, $tournID, $uid)) {
+	if (!validate_registration($state, $tournID, $uid, Status::RegClosedRequestsOpen)) {
 		return;
 	}
 
diff --git a/registration_validation.php b/registration_validation.php
index 2c1e258..7ed3676 100644
--- a/registration_validation.php
+++ b/registration_validation.php
@@ -2,7 +2,7 @@
 
 require_once __DIR__ . "/classes/Status.php";
 
-function validate_registration($state, $tournID, $uid) {
+function validate_registration($state, $tournID, $uid, $minStatus = 1) {
 	// Get information about our tournament
 	$tourn = $state->db->fetch("SELECT status, created_at, team_size, min_team_size, exclusivity_starts, exclusivity_ends FROM tournaments WHERE id = ?", [$tournID]);
 	if (!$tourn || $tourn["status"] == Status::Organising) {
@@ -13,7 +13,7 @@ function validate_registration($state, $tournID, $uid) {
 	$starts = $tourn["exclusivity_starts"];
 	$ends   = $tourn["exclusivity_ends"];
 
-	if ($tourn["status"] > 2) { // TODO make this for registrations only, not invites
+	if ($tourn["status"] > $minStatus) {
 		error_message("No more registrations are allowed.", 403);
 		return false;
 	}