Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holidays: Remove manually defined holidays once supported by python-holidays #295

Closed
ourownstory opened this issue Mar 18, 2021 · 2 comments · Fixed by #1176
Closed

Holidays: Remove manually defined holidays once supported by python-holidays #295

ourownstory opened this issue Mar 18, 2021 · 2 comments · Fixed by #1176
Assignees
@noxan
Labels
good first issue Good for newcomers priority:P3 Low priority task Tasks (not an epic, not a bug)

Comments

@ourownstory
Copy link
Owner

ourownstory commented Mar 18, 2021 •
edited
Loading

Added an Issue to python-holidays:
https://github.com/dr-prodigy/python-holidays/issues/538
@ourownstory
Copy link
Owner Author

Does prophet still do this?

@ourownstory ourownstory linked a pull request Oct 7, 2021 that will close this issue
Fix hdays #398
Merged
@ourownstory ourownstory removed a link to a pull request Oct 7, 2021
Fix hdays #398
Merged
@ourownstory ourownstory changed the title Holidays: rethink manually defined holidays class (first check default library) Holidays: Remove manually defined holidays once supported by python-holidays Oct 7, 2021
@karl-richter karl-richter moved this to Simplify & Clean in V1.0 Feb 17, 2023
@karl-richter
Copy link
Collaborator

Missing holidays added by https://github.com/dr-prodigy/python-holidays/pull/887

@noxan noxan removed the refactoring label Feb 24, 2023
@noxan noxan self-assigned this Feb 24, 2023
@noxan noxan added good first issue Good for newcomers priority:P3 Low priority task Tasks (not an epic, not a bug) labels Feb 24, 2023
@arkid15r arkid15r mentioned this issue Feb 28, 2023
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from Simplify & Clean to Done in V1.0 Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noxan noxan

Labels
good first issue Good for newcomers priority:P3 Low priority task Tasks (not an epic, not a bug)
Projects
V1.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] Update python-holidays integration arkid15r/neural-prophet
4 participants
@noxan @ourownstory @karl-richter @fjosp