Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data tables appear to be empty for charts with sparse data #2876

Closed
Tracked by #3175
sophiamersmann opened this issue Oct 30, 2023 · 1 comment
Closed
Tracked by #3175

Data tables appear to be empty for charts with sparse data #2876

sophiamersmann opened this issue Oct 30, 2023 · 1 comment

Comments

@sophiamersmann
Copy link
Member

sophiamersmann commented Oct 30, 2023

Description

  • We recently made Grapher's data table respect tolerance (prev. tolerance was essentially set to +/- infinity for data tables in range mode)
  • As a result, we often show empty cells where previously we would have showed a value from another year
  • This is usually ok but if dealing with sparse data, the default table view might be completely empty, and it is quite difficult to "find" a data value using the time slider
    • We sometimes have weekly/monthly data that is encoded as daily data (because there is no other way currently) – such data is by definition very sparse

Expected behaviour

The data table view should be useful for all charts, including charts with sparse data.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to https://ourworldindata.org/grapher/covid-vaccine-by-age?tab=table
  2. Note that the default view of the table is empty

Screenshots

Screenshot 2023-10-30 at 12 16 17

Additional context

It might be better to solve this issue on the data side, i.e. set appropriate tolerance values when necessary.

@sophiamersmann sophiamersmann changed the title Data tables appears to be empty for charts with sparse daily data Data tables appear to be empty for charts with sparse daily data Oct 30, 2023
@sophiamersmann sophiamersmann changed the title Data tables appear to be empty for charts with sparse daily data Data tables appear to be empty for charts with sparse data Dec 29, 2023
@danyx23
Copy link
Contributor

danyx23 commented Feb 7, 2024

Decided that since you can set tolerance, this is probably not worth the effort rn (given that covid is also less important than it used to be)

@danyx23 danyx23 closed this as completed Feb 7, 2024
@larsyencken larsyencken closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants