Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error/help message wording when no country is selected #4466

Open
sophiamersmann opened this issue Jan 20, 2025 · 1 comment
Open
Labels

Comments

@sophiamersmann
Copy link
Member

Description

If no country is selected, Grapher (sometimes) says 'No matching data' and then in a smaller font size 'Try adding countries and regions to display data'. Users might not understand what 'No matching data' means – as noted by Bobbie.

Note that other charts do have a more specific error message, for example this one

Expected behaviour

We should say 'No [entity types] selected' when appropriate.

While we're at, it might make sense to revise other error/help messages as well.

Steps to reproduce

  1. Go to https://ourworldindata.org/grapher/obesity-prevalence-adults-who-gho?tab=chart

Screenshots

Image

@marcelgerber
Copy link
Member

marcelgerber commented Jan 22, 2025

Yeah, we should revise the wording here, to something like:

  • "No [entity type] selected" (for when the selection is completely empty)
  • "No data for the currently selected [entity types]"

as they apply.

We could also add a button/link that would make it easy to select "World", if that's present in the chart.

@marcelgerber marcelgerber added priority 3 - nice to have soonish and small Do it some time soon like next cooldown and removed needs triage labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants