Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (explorer) dismiss focus state after unselecting an entity #4365

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

sophiamersmann
Copy link
Member

Fixes #4357

If a focused entity is unselected, then it should be un-focused as well. We do this for charts, but I forgot to do this for explorers.

@owidbot
Copy link
Contributor

owidbot commented Jan 2, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-explorers-dismiss-focus-afte

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-02 12:18:37 UTC
Execution time: 1.19 seconds

@sophiamersmann sophiamersmann merged commit 3eda0e1 into master Jan 2, 2025
25 checks passed
@sophiamersmann sophiamersmann deleted the explorers-dismiss-focus-after-unselecting branch January 2, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't escape 'focus mode' if focussed entity is unselected in an explorer
2 participants