Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed german/english GUI #8012

Closed
jnweiger opened this issue Aug 14, 2020 · 12 comments
Closed

Mixed german/english GUI #8012

jnweiger opened this issue Aug 14, 2020 · 12 comments
Assignees

Comments

@jnweiger
Copy link
Contributor

Seen on Centos-7.8 Gnome -- german desktop settings

image

Some button labels are untranslated. Hide, No, Yes.
Expected: German translations.

@TheOneRing
Copy link
Contributor

The missing translations for yes now indicate a missing or not loaded translations file for Qt, do you ship qtbase_de.qm and qt_de.qm .

Hide is a custom string and needs to be translated in transifex.

@jnweiger
Copy link
Contributor Author

jnweiger commented Aug 17, 2020

Ah, this is a gnome desktop. There are no Qt components in the system unless we bring them as part of the ownCloud clent install.
Neither qtbase_de.qm nor qt_de.qm are installed.
Can we add 'yes' and 'no' to our transifex as a fallback, so that they are used when there is nothing in the system?

@TheOneRing
Copy link
Contributor

It shouldn't have to do anything to do with the system, we always install our own Qt so we also should install our own Qt's translations.

@jnweiger
Copy link
Contributor Author

Ok. No, on Linux, we don't seem to bring our own Qt translations.

My Ubuntu testsystem has /usr/share/qt5/translations/qtbase_de.qm, but my CentOS has nothing.
We need to have our copies under /opt/ownCloud then...

@jnweiger jnweiger self-assigned this Aug 17, 2020
@jnweiger
Copy link
Contributor Author

A new package ocqt5129-qt5-qttranslations is on the horizon. That should provide us with stock Qt translations.

@jnweiger
Copy link
Contributor Author

Manually installing the translations package gets me the yes / no translations nicely:

image

There are now

/opt/ownCloud/qt-5.12.9/share/qt5/translations/qt_de.qm
/opt/ownCloud/qt-5.12.9/share/qt5/translations/qtbase_de.qm
...

@TheOneRing
Copy link
Contributor

so I guess we can close the issue then?

@jnweiger
Copy link
Contributor Author

jnweiger commented Aug 17, 2020

For #7966 release testing

@jnweiger
Copy link
Contributor Author

jnweiger commented Aug 18, 2020

@dschmidt

With the new dependency added, I can no longer install from: https://download.owncloud.com/desktop/ownCloud/daily/2.7/linux/download/

 owncloud-client : Depends: ocqt5129-qttranslations5 but it is not installable
E: Unable to correct problems, you have held broken packages.

What do we have to do, so that the dependency shows up in the downoad repo?

@dschmidt
Copy link
Member

@jnweiger rebuild the build images?

@jnweiger
Copy link
Contributor Author

jnweiger commented Aug 18, 2020

After a long day of studying and hacking, drone finally rebuilt the build images. https://drone.owncloud.services/client/build-linux/1658/

@jnweiger
Copy link
Contributor Author

image
Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants