Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trash bin does not work #47

Closed
butonic opened this issue Nov 11, 2019 · 3 comments
Closed

Trash bin does not work #47

butonic opened this issue Nov 11, 2019 · 3 comments

Comments

@butonic
Copy link
Member

butonic commented Nov 11, 2019

reported in #45

@butonic butonic added the Bug label Nov 11, 2019
@butonic butonic self-assigned this Nov 12, 2019
@butonic
Copy link
Member Author

butonic commented Nov 12, 2019

https://github.com/cs3org/reva/blob/master/internal/grpc/services/gateway/storageprovider.go#L380-L387

func (s *svc) ListRecycle(ctx context.Context, req *gatewayv0alphapb.ListRecycleRequest) (*storageproviderv0alphapb.ListRecycleResponse, error) {
	// TODO(labkode): query all available storage providers to get unified list as the request does not come
	// with ref information to target only one storage provider.
	res := &storageproviderv0alphapb.ListRecycleResponse{
		Status: status.NewUnimplemented(ctx, nil, "ListRecycle not yet implemented"),
	}
	return res, nil
}

@butonic
Copy link
Member Author

butonic commented Nov 12, 2019

a problem with the trashbin arose: phoenix and other clients need to construct a Destination url. They seem to assume the dav/files/ structure. I got this in the browser:

curl 'http://localhost:20080/remote.php/dav/trash-bin/einstein/foo1.txt.d1573466248' -X MOVE -H 'Sec-Fetch-Mode: cors' -H 'authorization: Bearer wIa7TxfFatQ_kiH_ySVNzVbwmv3Ouwz06GDeesv5yVM.dniRFghcN7vK0sT--6w6kCCdBaWaoAAiIrYnooiWm2M' -H 'OCS-APIREQUEST: true' -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36' -H 'Referer: http://localhost:8300/' -H 'X-Requested-With: XMLHttpRequest' -H 'Overwrite: F' -H 'Destination: http://localhost:20080/remote.php/dav/files/einstein//oc/foo1.txt' --compressed

EDIT: hm the dav/trash-bin handler might rewrite the Destination header in the ocdav endpoint

@butonic
Copy link
Member Author

butonic commented Nov 12, 2019

list & undelete & purge fixed by cs3org/reva#370

@butonic butonic removed their assignment Nov 12, 2019
@butonic butonic mentioned this issue Nov 14, 2019
@butonic butonic closed this as completed Nov 22, 2019
refs pushed a commit that referenced this issue Sep 18, 2020
refs pushed a commit that referenced this issue Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant