From 8dd0013e7220ac9460cb99f1d6ce864da77502a4 Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Thu, 16 Jan 2025 11:00:11 +0000
Subject: [PATCH] refactor(linter/consistent-function-scoping): remove
 `Visit::enter_node` usage (#8538)

Use `Visit::visit_*` method instead of `Visit::enter_node` / `leave_node`. A step towards solving #8461, but also may improve performance.
---
 .../unicorn/consistent_function_scoping.rs    | 21 +++++++------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/crates/oxc_linter/src/rules/unicorn/consistent_function_scoping.rs b/crates/oxc_linter/src/rules/unicorn/consistent_function_scoping.rs
index fbe494c9f6e07..997e62bbc8aff 100644
--- a/crates/oxc_linter/src/rules/unicorn/consistent_function_scoping.rs
+++ b/crates/oxc_linter/src/rules/unicorn/consistent_function_scoping.rs
@@ -1,9 +1,10 @@
-use oxc_ast::{AstKind, Visit};
+use rustc_hash::FxHashSet;
+
+use oxc_ast::{visit::walk, AstKind, Visit};
 use oxc_diagnostics::OxcDiagnostic;
 use oxc_macros::declare_oxc_lint;
-use oxc_semantic::ReferenceId;
+use oxc_semantic::{ReferenceId, ScopeFlags};
 use oxc_span::{GetSpan, Span};
-use rustc_hash::FxHashSet;
 
 use crate::{
     ast_util::{get_function_like_declaration, nth_outermost_paren_parent, outermost_paren_parent},
@@ -283,16 +284,10 @@ impl<'a> Visit<'a> for ReferencesFinder {
         }
     }
 
-    fn enter_node(&mut self, kind: AstKind<'a>) {
-        if let AstKind::Function(_) = kind {
-            self.in_function += 1;
-        }
-    }
-
-    fn leave_node(&mut self, kind: AstKind<'a>) {
-        if let AstKind::Function(_) = kind {
-            self.in_function -= 1;
-        }
+    fn visit_function(&mut self, func: &oxc_ast::ast::Function<'a>, flags: ScopeFlags) {
+        self.in_function += 1;
+        walk::walk_function(self, func, flags);
+        self.in_function -= 1;
     }
 }