Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a LeaseError type, instead of () #54

Open
mkeeter opened this issue Aug 20, 2024 · 0 comments · May be fixed by #55
Open

Add a LeaseError type, instead of () #54

mkeeter opened this issue Aug 20, 2024 · 0 comments · May be fixed by #55

Comments

@mkeeter
Copy link
Contributor

mkeeter commented Aug 20, 2024

Many functions return Result<(), ()>, which is a little weird looking!

Having a LeaseError (or LeaseReadError / LeaseWriteError) would make this less weird, even if it's a simple empty struct.
@mkeeter mkeeter linked a pull request Aug 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add specific lease read and write errors oxidecomputer/idolatry
1 participant
@mkeeter