Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icc_examin interface changes #2

Open
beku opened this issue Mar 15, 2015 · 1 comment
Open

icc_examin interface changes #2

beku opened this issue Mar 15, 2015 · 1 comment

Comments

@beku
Copy link
Member

beku commented Mar 15, 2015

  1. The profile black points are shown as x=0, y=0. But X=Y=Z=0 doesn't mean x=y=0: http://www.brucelindbloom.com/index.html?Eqn_XYZ_to_xyY.html
    "Watch out for black, where X = Y = Z = 0. In that case, you may want to set x and y to the chromaticity coordinates of your reference white."

    For white point 0.964203, 1.000000, 0.824905:
    x= 0.964203/(0.964203+1.000000+0.824905)=0.964203/2.789108=0.345703
    y= 1.000000/(0.964203+1.000000+0.824905)=1.000000/2.789108=0.358537

    I seem to recall seeing x=y=0.333333 as the chromaticity coordinates for black in old V2 matrix profiles.

  2. Red Colorant, Blue Colorant, and Green Colorant in the top pane, when clicked, all show exactly the same information, the red, blue, and green XYZ primaries and the xy points on the xy graph. Why not just have "Colorants" instead of three separate entries for the same information display?

  3. Red tone reproduction curve, Green tone reproduction curve, and Blue tone reproduction curve in the top pane, when clicked, all show exactly the same information, all three curves at once. Why not just have "Tone reproduction curves" instead of three separate entries for the same information display?

  4. I would very much like to see the xyY coordinates as well as the XYZ coordinates.

  5. The Colorant display is too small for displaying information for larger color spaces such as the Identity color space and the ACES color space, both of which use green chromaticity of x=0,y=1. The ACES color space has a negative blue y coordinate, and so is crushed and the blue dot isn't on the graph. The Colorant display for Widegamut Green is overwritten/crushed. The solution is to let the xy chromaticities diagram be a little larger, extend to a little past +1 on the positive y-axis. For the negative y-axis, down to -0.1 on the y axis accomodates ACES. Camera input matrix profiles can go even more negative for blue XYZ. My own camera has: bXYZ=0.056061, -0.204941, 0.989136

  6. The chrm Chromaticity information is similarly crushed for the larger color spaces, with information being overwritten by other information. A larger chromaticity diagram would help here, too.

  7. Without asking permission, opening an ICC profile with icc_examin automatically creates and writes a profileID tag. Perhaps this should be configurable? Is it already configurable? I don't like seeing my ICC profiles written to without permission. Although I do agree a profileID is a nice tag to have.

  8. The very nice gamut display that I remember seeing is just a mass of jumbled gray and black dots. If I resize the screen, the jumble changes color. The terminal output is:
    iccexamin
    region not found in 0
    X_ChangeProperty: BadAtom (invalid Atom parameter) 0x0

  9. There doesn't seem to be provision for copying values from the iccexamin interface.

@beku
Copy link
Member Author

beku commented Mar 15, 2015

  1. confirmed, the black point should appear on the black body line for XYZ=0,0,0
  2. ICC Examin thries to be technical correct. So each tag is listed separately. Otherwise users might not understand which is the relation to tools like iccdump, iccProfileDump or oyranos-profile.
  3. same like 1(b)
  4. you mean textual representations? for which tags?
  5. yes, XYZ.icc is not shown nicely. Perhaps scale to fit would be better here. The code for this to change is in icc_draw.cpp .
  6. agreed
  7. I have here plenty profiles with wrong ID's and nothing gets repaired automatically. Can you attach a profile to reproduce please?
  8. sounds like a bug in the OpenGL usage. Is Mesa installed properly? Runs glgears and glinfo properly?
  9. Thats primarily a toolkit issue. A different widget might help. That feature has not high priority to me personally.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant