-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert HTML to JSX Components #51
Comments
Hi! I examined the html files that need to be converted and saw that inline CSS was written in a few places. How would you like this CSS to be used in the newly created jsx files? |
Hi @UmaySoyluer, If you're interested in working on this, let me know, I can assign it to you. |
Thanks for pointing that out. I'm interested in working on this , so please go ahead and assign it to me. I'll make sure to sync my branch with PR 54 for v4.0 and set the base to w3up-client. |
Assigned |
@UmaySoyluer btw, I've added the SVGs in |
yes, i used the SVGs in that folder. Since the logo were available as PNG i used it that way. |
Thanks, I am planning to release version 4.0 on Saturday. If you require more time, please feel free to do so. In that case, you may set the |
Actually, only the last step, the handleContinueWithSavedSpace function update and webpack configuration, remains. Let me push the changes I made and continue working on the config until release. |
can you please give me write permission so i can push refactor changes? |
Pull Request would work, no need for write access. |
I couldn't push because permission is denied , so i can't create a PR. |
Looks like you're new to open-source. |
Yes, I'm relatively new to open source. Initially, when I forked the repository, there were no w3up-client branch which i should use as a base. Therefore, I cloned directly from the original repository, which resulted in a permission issue. Sorry for the inconvenience. |
TODOs:
handleContinueWithSavedSpace
function andhandleContinueWithSavedSpace
button) and webpack.config.js accordingly.Expected Outcome:
assets
directory.The text was updated successfully, but these errors were encountered: