Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma points and DOS calculations #244

Open
ajjackson opened this issue Oct 10, 2022 · 2 comments
Open

Gamma points and DOS calculations #244

ajjackson opened this issue Oct 10, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@ajjackson
Copy link
Collaborator

I've hit another "fun" problem with LO-TO splitting in DOS calculations!

While we do suggest that the Gamma point is avoided for DOS calculations, it is quite likely to be included as part of some symmetrised selection of points. Indeed spglib can only produce symmetry-reduced Gamma-centered meshes.

However, when dipole terms are included, the Gamma point frequencies depend on the order q-points are specified, e.g. for the test quartz force constants

fc.calculate_qpoint_phonon_modes(np.array([[0., 0., 0.], [0.5, 0., 0.]])).frequencies[:, -1]

> [152.81266107583681 148.48620386064283] millielectron_volt

fc.calculate_qpoint_phonon_modes(np.array([[0., 0., 0.], [0., 0., 0.5]])).frequencies[:, -1]

> [154.00566951775016 150.66306582308405] millielectron_volt

This makes it difficult to compare sampling schemes as the seemingly-insignificant implementation detail of q-point order determines the resulting spectrum.

For band structure plots this behaviour is correct, but for DOS perhaps it would be more correct to use the Gamma-point without non-analytic corrections, even though other points near Gamma use it? Would it be appropriate to provide a way of disabling this at Gamma?

@rebeccafair
Copy link
Member

Have you tried setting splitting=false in calculate_qpoint_phonon_modes? This should still apply the dipole correction to all q-points but just not the non-analytical correction at gamma.

@ajjackson
Copy link
Collaborator Author

ajjackson commented Oct 12, 2022

Aha, I forgot that was there 🤦 Yes, that seems to fix it perfectly and gets me back on track for sampling work.

I think we should consider using this setting for the euphonic-dos command-line tool as well as any automatic Debye-Waller factor calculations. (i.e. GP splitting should only be enabled for band-structure calculations.)

@ajjackson ajjackson added the good first issue Good for newcomers label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants