Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multifit tests use the obsolete multifit and/or fit syntax #217

Open
tgperring opened this issue Aug 20, 2020 · 1 comment
Open

Multifit tests use the obsolete multifit and/or fit syntax #217

tgperring opened this issue Aug 20, 2020 · 1 comment
Labels
HoraceMirror To be removed? Testing Related to testing Tobyfit Task Location

Comments

@tgperring
Copy link
Collaborator

Many of the multifit tests in Horace and Herbert use the legacy - now obsolete - calling syntax. These need to be converted to use the object-oriented multifit syntax.

Many multifit tests also use the legacy - now obsolete - fit methods. Users should be directed to use multifit instead rather than to the legacy function
@nickbattam-tessella
Copy link
Member

Related to pace-neutrons/Horace#312

@nickbattam-tessella nickbattam-tessella mentioned this issue Aug 20, 2020
Closed
@oerc0122 oerc0122 added HoraceMirror To be removed? Testing Related to testing Tobyfit Task Location labels Dec 3, 2020
@oerc0122 oerc0122 mentioned this issue Jan 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HoraceMirror To be removed? Testing Related to testing Tobyfit Task Location
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oerc0122 @nickbattam-tessella @tgperring