Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of improvements (feedback after creating migrations for Packit 1.0.0) #4

Open
majamassarini opened this issue Dec 12, 2024 · 0 comments

Comments

@majamassarini
Copy link
Member

majamassarini commented Dec 12, 2024

Before using the packit_config_checker script again I suggest to:

  • The script is now looking for the last year active projects so I ended up with some old configs not updated by the script, one project turned out to be still actively maintained (the configs were already downloaded some time ago). We should probably warn the user to download the configs in a clean directory and probably it is safer to get the configs for all the projects (not just those active the latest year).
  • We should update the already created packit forks for github and gitlab (pagure should be already implemented).
  • Probably could be useful to be able to force-push an already create PR with some changes if we realize there is a mistake for one or more projects.
  • Mirek suggested that in Update Packit configuration rpm-software-management/distribution-gpg-keys#125 he prefers if comment #0 would contain the same message as commit description. Probably the long comment should be used only in the PR description.
  • the script always propose PR in upstream, when it exists, but projects can have the sync_from_downstream job enabled! So there is a chance that it will be later overwritten...
  • even though the upstream project has merged the Packit proposed upstream PR, until propose-downstream is run and the packit created PRs are merged, the downstream config may remain broken and out of sync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: backlog
Development

No branches or pull requests

2 participants