Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from redis #561

Closed
7 tasks
mfocko opened this issue Apr 15, 2024 · 1 comment · Fixed by #569
Closed
7 tasks

Move away from redis #561

mfocko opened this issue Apr 15, 2024 · 1 comment · Fixed by #569
Assignees
Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.

Comments

@mfocko
Copy link
Member

mfocko commented Apr 15, 2024

In the light of redis/redis#13157 and sudden cut-off of sclorg/redis-7 that caused a disruption of our production deployment on Thursday, it's time to move away from the redis

TODO:

  • research possible alternatives (list of them, given by Mirek, follows):
    • Valkey - fork of Redis 7. Under Linux Foundation. Continue under BSD license.
    • Redict - fork of Redis 7. Hey, never again such problem with license. Let's change license to LGPL-3.0-only.
    • KeyDB - forked long time ago, when there was past issue with license. Based on Redis 6. Added multithreading, which add level of complexity on the simplicity for which was Redis heavily used.
  • look around for images customized for OpenShift (such as https://github.com/sclorg/redis-container that we used)
  • check if it's possible to swap 1:1 without »much« additional overhead
  • “swish swish”1

Footnotes

  1. switch to the alternative…

@mfocko mfocko added area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related. labels Apr 15, 2024
@lbarcziova lbarcziova moved this from new to priority-backlog in Packit Kanban Board Apr 16, 2024
@lbarcziova lbarcziova moved this from priority-backlog to refined in Packit Kanban Board Apr 18, 2024
@mfocko mfocko self-assigned this Apr 23, 2024
@mfocko mfocko moved this from refined to in-progress in Packit Kanban Board Apr 23, 2024
mfocko added a commit to mfocko/deployment that referenced this issue Apr 24, 2024
@mfocko mfocko linked a pull request Apr 29, 2024 that will close this issue
@mfocko mfocko moved this from in-progress to in-review in Packit Kanban Board Apr 29, 2024
@mfocko
Copy link
Member Author

mfocko commented Apr 29, 2024

  • There's redict currently deployed (since Tuesday; Apr 23) on both production and stage
  • There's been an issue hit with the flower not being reconfigured to monitor the redict instead of redis; discovered by @lbarcziova on Wednesday morning
    • However as I'm noting this down, I realized that redis was set up as a redict replica (read-only, same contents as redict), therefore I don't really understand how did it manage to set off the alerts…
  • Smallish issue has been hit on the Thursday afternoon, first-response and fix by @nforro; appears to be caused by network flakes
    • Redict logs: Redis requested multiple times resync, failed on timeout and Connection reset; cause of restarts is unknown
    • Sentry events: related to the Redis sync and also failed connections to the Redict
    • @mfocko scaled down Redis on Monday as it doesn't appear we're hitting any blockers and will need to quick swap

@mfocko mfocko closed this as completed in e3749af May 2, 2024
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant