Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement OpenScanHub integration prototype #2463

Closed
4 tasks
lbarcziova opened this issue Jul 11, 2024 · 0 comments · Fixed by #2472
Closed
4 tasks

Implement OpenScanHub integration prototype #2463

lbarcziova opened this issue Jul 11, 2024 · 0 comments · Fixed by #2472
Assignees
@lbarcziova
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement.

Comments

@lbarcziova
Copy link
Member

lbarcziova commented Jul 11, 2024 •
edited by mfocko
Loading

  • after successful RPM build for rawhide only (somewhere here), call the previously mentioned functionality if there is a job with job:copr_build, trigger:commit, branch: <target branch of the PR> in the config (and if the new config option is set to True)
    • from this job obtain the Copr project name and from that the project's latest SRPM build
  • report the submission of the scan via one new check run/commit status with a successful state and provide the URL of the scan
  • (optionally) post a comment with link to docs/blogpost about this functionality, the comments should not be too intrusive
    • maybe have some limit on the comments, e.g., once per PR or project

For the purposes of the prototype, we don't have to store anything in DB, but the first step can be extending SRPMBuildTargetModel with URL to scan and the final solution would require a more complex DB design (referencing both SRPMs, URL to scan, datetime, ..).

Followup of #2454

Part of #2107
This was referenced Jul 11, 2024
Closed
Closed
@lbarcziova lbarcziova added kind/feature New feature or a request for enhancement. area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/high This brings a lot of value to (not strictly a lot of) users. labels Jul 11, 2024
@mfocko mfocko moved this from new to priority-backlog in Packit Kanban Board Jul 15, 2024
@mfocko mfocko moved this from priority-backlog to refined in Packit Kanban Board Jul 18, 2024
@lbarcziova lbarcziova self-assigned this Jul 22, 2024
@lbarcziova lbarcziova moved this from refined to in-progress in Packit Kanban Board Jul 22, 2024
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 23, 2024
@lbarcziova
Finish OpenScanHub integration prototype
49854ac 
Fixes packit#2463
@lbarcziova lbarcziova mentioned this issue Jul 23, 2024
Merged
3 tasks
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 23, 2024
@lbarcziova
Finish OpenScanHub integration prototype
e6c6ab7 
Fixes packit#2463
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 23, 2024
@lbarcziova
Finish OpenScanHub integration prototype
1d4d3b6 
Fixes packit#2463
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 23, 2024
@lbarcziova
Finish OpenScanHub integration prototype
08de2a7 
Fixes packit#2463
@lbarcziova lbarcziova moved this from in-progress to in-review in Packit Kanban Board Jul 24, 2024
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 24, 2024
@lbarcziova
Finish OpenScanHub integration prototype
160a3c0 
Fixes packit#2463
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 24, 2024
@lbarcziova
Finish OpenScanHub integration prototype
5cea038 
Fixes packit#2463
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 24, 2024
@lbarcziova
Finish OpenScanHub integration prototype
f7722b5 
Fixes packit#2463
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 24, 2024
@lbarcziova
Finish OpenScanHub integration prototype
9b2196e 
Fixes packit#2463
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 24, 2024
@lbarcziova
Finish OpenScanHub integration prototype
0e5db59 
Fixes packit#2463
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 24, 2024
@lbarcziova
Finish OpenScanHub integration prototype
7f36a8e 
Fixes packit#2463
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jul 25, 2024
@lbarcziova
Finish OpenScanHub integration prototype
2d0da30 
Fixes packit#2463
softwarefactory-project-zuul bot added a commit that referenced this issue Jul 25, 2024
@softwarefactory-project-zuul
Implement OpenScanHub prototype (#2472)
8de1710 
Implement OpenScanHub prototype

Fixes #2454
Fixes #2463
TODO:

 docs
 better error handling
 better marketing - adding to news footer,.. - this can be done as a followup after running in prod for a week to see if everything works as expected

RELEASE NOTES BEGIN
We have added the initial version of functionality for running scans in OpenScanHub. You can read more about this functionality
here.
RELEASE NOTES END

Reviewed-by: Siteshwar Vashisht
Reviewed-by: Laura Barcziová
Reviewed-by: Nikola Forró
Reviewed-by: Matej Focko
Reviewed-by: František Lachman <[email protected]>
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Jul 25, 2024
@lbarcziova lbarcziova mentioned this issue Jul 26, 2024
Merged
mfocko added a commit to packit/deployment that referenced this issue Jul 29, 2024
@mfocko
Adjust packit-config volume in packit-worker (#587)
c46a5c4 
Add the configuration needed for OpenScanHub integration and adjust the
packit-config volume so that the config is being mounted in the
subdirectory along the existing secrets.

Followup of packit/packit-service#2463

This now runs on staging and works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement OpenScanHub prototype lbarcziova/packit-service
1 participant
@lbarcziova