Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Priority Moves used in Psychic Terrain Display Incorrect Battle Text #5081

Open
KennethWest opened this issue Jan 4, 2025 · 5 comments · May be fixed by #5091
Open

[Bug] Priority Moves used in Psychic Terrain Display Incorrect Battle Text #5081

KennethWest opened this issue Jan 4, 2025 · 5 comments · May be fixed by #5091
Labels
Move Affects a move P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.

Comments

@KennethWest
Copy link

Describe the bug

Whenever a priority move is used in Psychic Terrain the text that displays afterwards says the Pokémon that used the priority move is protected by Psychic Terrain rather than the Pokémon being attacked.

Reproduction

Use any priority move in Psychic Terrain.

Expected behavior

In the example below the text reads "Wild Ariados is protected by the Psychic Terrain" after using Sucker Punch. I would expect the text to read either "Delphox is protected by the Psychic Terrain" or "Gallade is protected by the Psychic Terrain".

Screenshots / Videos

Psychic.Terrain.Text.Bug.mp4

Session export file

No response

User data export file

No response

Additional context

No response

@KennethWest KennethWest added the Triage The issue needs triage label Jan 4, 2025
@Snailman11
Copy link
Collaborator

Does this occur in singles?

@Snailman11 Snailman11 added Move Affects a move P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. and removed Triage The issue needs triage labels Jan 4, 2025
@Snailman11
Copy link
Collaborator

This might not just be visual, if the grounded check is done on the user and not the opponent

For five turns, Pokémon on the ground won't be hit by priority moves. The power of Psychic-type moves is boosted.

@KennethWest
Copy link
Author

Does this occur in singles?

Yes. From what I've observed it occurs in any battle type so long as there is psychic terrain.

@KennethWest
Copy link
Author

KennethWest commented Jan 4, 2025

This might not just be visual, if the grounded check is done on the user and not the opponent

For five turns, Pokémon on the ground won't be hit by priority moves. The power of Psychic-type moves is boosted.

src/data/terrain.ts

   isMoveTerrainCancelled(user: Pokemon, targets: BattlerIndex[], move: Move): boolean {
    switch (this.terrainType) {
      case TerrainType.PSYCHIC:
        if (!move.hasAttr(ProtectAttr)) {
          // Cancels move if the move has positive priority and targets a Pokemon grounded on the Psychic Terrain
          return move.getPriority(user) > 0 && user.getOpponents().some(o => targets.includes(o.getBattlerIndex()) && o.isGrounded());
        }
    }

    return false;

this block implies that the check for grounded happens correctly

@Snailman11 Snailman11 moved this from To triage to Ready in PokéRogue Bug Management Jan 5, 2025
@Snailman11
Copy link
Collaborator

Visual Only
PokeRogue.and.10.more.pages.-.Personal.-.Microsoft.Edge.2025-01-04.17-47-54.mp4
Occurs in Singles
PokeRogue.and.10.more.pages.-.Personal.-.Microsoft.Edge.2025-01-04.17-48-38.mp4

KennethWest added a commit to KennethWest/KenWestPokeRogueFork that referenced this issue Jan 5, 2025
@Snailman11 Snailman11 moved this from Ready to In review in PokéRogue Bug Management Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move Affects a move P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Projects
Status: In review
2 participants