Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple downstream devices on same interface #39

Open
ghost opened this issue Aug 6, 2018 · 2 comments
Open

multiple downstream devices on same interface #39

ghost opened this issue Aug 6, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 6, 2018

when i read the code correct:

- acceptLeaveMessage
... calls
- setRouteLastMemberMode
...
 if (numberOfInterfaces(croute) <= 1) {
                my_log(LOG_DEBUG, 0, "Leaving group %d now", group);
                sendJoinLeaveUpstream(croute, 0);
}

In case we have multiple devices on one downstream interface, that have joined this group, the current implementation immediately sends a leave message upstream. Which is a problem for all the other devices, which have not send a leave message yet.

@tiba222
Copy link

tiba222 commented Feb 23, 2020

I just created a pull request with a solution for this #57.

Of course I'm open for suggestions but for me the changes in that pull request have fixed this issue.

@pali
Copy link
Owner

pali commented Feb 27, 2020

Just to note that this is only specific to the quickleave mode which is not fully compatible with IGMPv2 protocol. So fix (or rather workaround) to this problem is to turn off quickleave mode. But in #57 we try to improve current situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants