Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore const network = process.argv[2]; currently hardcoded to testnet #31

Open
1 task
chopan123 opened this issue Jul 4, 2024 · 6 comments
Open
1 task

Comments

@chopan123
Copy link
Member

chopan123 commented Jul 4, 2024

In order to make the typescript tests work we have hardcoded the network to testnet:

this occurs on contracts/utils/contract.ts and contracts/utils/tx.ts

Acceptance criteria:

  • Don't break the typescript tests, or modify them to not break them
@od-hunter
Copy link

od-hunter commented Jul 4, 2024

Hi @chopan123 Is this open for contribution, if yes can I be assigned this please? I’m a blockchain developer and I’m ready to work. Here is the link to my profile: https://app.onlydust.com/u/od-hunter

@BraCR10
Copy link
Contributor

BraCR10 commented Jul 5, 2024

Hello @chopan123 , in my last contribution I made the TS test #19, in order to make the test work I had to navigate within these files and make those small changes, I would like to investigate more and try to solve it, could I take the issue?

@PrincesoDan
Copy link

Hi @chopan123, is this task still open? I'd like to see if I can work on it.

Copy link

onlydustapp bot commented Aug 27, 2024

Hey @PrincesoDan!
Thanks for showing interest.
We've created an application for you to contribute to Get your Soroban journey started⚽! with create-soroban-dapp.
Go check it out on OnlyDust!

@Yunusabdul38
Copy link

@chopan123 I'd love to work on this

@OWK50GA
Copy link

OWK50GA commented Dec 8, 2024

Hi, @chopan123
I'd love to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants