5 [Vault] Unbounded Gas Consumption in Loops for Fee Distribution and Asset Management

[chopan123]

Check the limits on when it is going to fail.

• How many Asset, Strategies we need to add to make distribute_fee reach Soroban limits?
• How many instructions of each type do we need to read soroban limits when executing rebalance ?
• How many asset, strategies we need to add to make emergency_withdraw fail ?
• How many Asset, Strategies Deposit with invest in true
• How many Asset, Strategies Withdraw with amount bigger than idle funds

note Try 1 asset, find n strategies. then n assets, 1 strategy per asset.
Test it using Blend strategies.
use budget too

[joaquinsoza]

1 Asset n Strategies Hodl

• 13 Hodl Strategies pass
• 14 Hodl Strategies hits memory limit on withdrawal

1 Asset n Strategies Fixed

• 10 Fixed Strategies pass
• 11 Fixed Strategies hits memory limit on withdrawal

1 Asset n Strategies Blend

• 2 Blend Strategies pass
• 3 Blend Strategies hits CPU Instructions limit on withdrawal

1 Asset 1 Strategy Hodl Rebalance Limits

• Invest hits MEMORY limit at 30 Instructions, 29 Passes
• Unwind hits MEMORY limit at 30 Instructions, 29 Passes

1 Asset 1 Strategy Fixed Rebalance Limits

• Invest hits MEMORY limit at 25 Instructions, 24 Passes
• Unwind hits MEMORY limit at 26 Instructions, 25 Passes

1 Asset 1 Strategy Blend Rebalance Limits

• Invest hits CPU limit at 5 Instructions, 4 Passes
• Unwind hits CPU limit at 6 Instructions, 5 Passes

2 Asset Swap Limits Rebalance

• SwapExactIn hits MEMORY limit at 6 Instructions, 5 Passes
• SwapExactOut hits MEMORY limit at 6 Instructions, 5 Passes

N Asset 1 Strategy Hodl

• Create Vault hits MEMORY limit at 27 Assets one strategy each, 26 Passes
• Deposit hits MEMORY limit at 26 Assets one strategy each, 25 Passes
• If sending all invest instructions together it hits the MEMORY limit at 25 Assets, 24 Passes. but it could be send in batches and we could have 25 Assets
• Deposit and Invest hits MEMORY limit at 14 Assets one strategy each, 13 Passes
• Withdraw hits MEMORY limit at 13 Assets one strategy each, 12 Passes
• MAX 12 Assets 1 Strategy each

N Asset 1 Strategy Fixed

• Create Vault hits MEMORY limit at 23 Assets one strategy each, 22 Passes
• Deposit hits MEMORY limit at 26 Assets one strategy each, 25 Passes
• If sending all invest instructions together it hits the MEMORY limit at 23 Assets, 22 Passes. but it could be send in batches and we could have 25 Assets
• Deposit and Invest hits MEMORY limit at 12 Assets one strategy each, 11 Passes
• Withdraw hits MEMORY limit at 11 Assets one strategy each, 10 Passes
• MAX 11 Assets 1 Strategy each

N Asset 1 Strategy Blend

• Create Vault hits MEMORY limit at 21 Assets one strategy each, 20 Passes
• Deposit hits MEMORY limit at 26 Assets one strategy each, 25 Passes
• If sending all invest instructions together it hits the CPU limit at 4 Assets, 3 Passes. but it could be send in batches and we could have 25 Assets
• Deposit and Invest hits CPU limit at 4 Assets one strategy each, 3 Passes
• Withdraw hits CPU limit at 5 Assets one strategy each, 4 Passes